fix(logger): no longer detects duplicate object as circular #1679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CorieW
force-pushed
the
@invertase/fix-logger-circular-removal
branch
from
7d2dcf2 to
0cbbf47
Compare
CorieW
force-pushed
the
@invertase/fix-logger-circular-removal
branch
from
0cbbf47 to
2e6bc64
Compare
cabljac
requested changes
Mar 19, 2025
Contributor
cabljac
left a comment
cabljac
left a comment
There was a problem hiding this comment.
generally lgtm, couple of questions though
CorieW
commented
Mar 19, 2025
CorieW
force-pushed
the
@invertase/fix-logger-circular-removal
branch
from
fce1dc5 to
cf2cb4d
Compare
cabljac
reviewed
Mar 19, 2025
taeold
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1510