Skip to content

Remove TODOs, update comments to look better on reference docs page. #1699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025
Merged

Remove TODOs, update comments to look better on reference docs page. #1699

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/v2/options.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ export function getGlobalOptions(): GlobalOptions {
* Additional fields that can be set on any event-handling function.
*/
export interface EventHandlerOptions extends Omit<GlobalOptions, "enforceAppCheck"> {
/** Type of the event. Valid values are TODO */
/** Type of the event. */
eventType?: string;

/**
Expand All @@ -274,10 +274,9 @@ export interface EventHandlerOptions extends Omit<GlobalOptions, "enforceAppChec
/**
* Filters events based on path pattern matching on the CloudEvents attributes.
*
* Similar to eventFilters, but supports wildcard patterns for flexible matching:
* - `*` matches any single path segment
* - `**` matches zero or more path segments
* - `{param}` captures a path segment as a parameter
* Similar to eventFilters, but supports wildcard patterns for flexible matching where `*` matches
* any single path segment, `**` matches zero or more path segments, and `{param}` captures a path segment
* as a parameter
*/
eventFilterPathPatterns?: Record<string, string | Expression<string>>;

Expand Down
Loading