Skip to content

Commit 125a6fe

Browse files
should verify mock object after expect (#8526)
1 parent bd9272c commit 125a6fe

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

FirebaseMessaging/Tests/UnitTests/FIRMessagingExtensionHelperTest.m

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -160,8 +160,9 @@ - (void)testDeliveryMetricsLoggingWithEmptyPayload {
160160
OCMStub([_mockUtilClass isAppExtension]).andReturn(YES);
161161
NSDictionary *fakeMessageInfo = @{@"aps" : @{}};
162162

163-
[_mockExtensionHelper exportDeliveryMetricsToBigQueryWithMessageInfo:fakeMessageInfo];
164163
OCMReject([_mockExtensionHelper bundleIdentifierByRemovingLastPartFrom:[OCMArg any]]);
164+
[_mockExtensionHelper exportDeliveryMetricsToBigQueryWithMessageInfo:fakeMessageInfo];
165+
OCMVerifyAll(_mockExtensionHelper);
165166
}
166167

167168
- (void)testDeliveryMetricsLoggingWithInvalidMessageID {
@@ -172,8 +173,9 @@ - (void)testDeliveryMetricsLoggingWithInvalidMessageID {
172173
@"google.c.fid" : @"fakeFIDForTest",
173174
@"google.c.sender.id" : @123456789
174175
};
175-
[_mockExtensionHelper exportDeliveryMetricsToBigQueryWithMessageInfo:fakeMessageInfo];
176176
OCMReject([_mockExtensionHelper bundleIdentifierByRemovingLastPartFrom:[OCMArg any]]);
177+
[_mockExtensionHelper exportDeliveryMetricsToBigQueryWithMessageInfo:fakeMessageInfo];
178+
OCMVerifyAll(_mockExtensionHelper);
177179
}
178180

179181
- (void)testDeliveryMetricsLoggingWithInvalidFID {
@@ -183,8 +185,9 @@ - (void)testDeliveryMetricsLoggingWithInvalidFID {
183185
@"fcm_options" : @{@"image" : @"https://google.com"},
184186
@"google.c.sender.id" : @123456789
185187
};
186-
[_mockExtensionHelper exportDeliveryMetricsToBigQueryWithMessageInfo:fakeMessageInfo];
187188
OCMReject([_mockExtensionHelper bundleIdentifierByRemovingLastPartFrom:[OCMArg any]]);
189+
[_mockExtensionHelper exportDeliveryMetricsToBigQueryWithMessageInfo:fakeMessageInfo];
190+
OCMVerifyAll(_mockExtensionHelper);
188191
}
189192

190193
- (void)testDeliveryMetricsLoggingWithDisplayPayload {
@@ -196,9 +199,9 @@ - (void)testDeliveryMetricsLoggingWithDisplayPayload {
196199
@"google.c.fid" : @"fakeFIDForTest",
197200
@"google.c.sender.id" : @123456789
198201
};
199-
200-
[_mockExtensionHelper exportDeliveryMetricsToBigQueryWithMessageInfo:fakeMessageInfo];
201202
OCMExpect([_mockExtensionHelper bundleIdentifierByRemovingLastPartFrom:[OCMArg any]]);
203+
[_mockExtensionHelper exportDeliveryMetricsToBigQueryWithMessageInfo:fakeMessageInfo];
204+
OCMVerifyAll(_mockExtensionHelper);
202205
}
203206

204207
- (void)testDeliveryMetricsLoggingWithDataPayload {
@@ -210,8 +213,9 @@ - (void)testDeliveryMetricsLoggingWithDataPayload {
210213
@"google.c.fid" : @"fakeFIDForTest",
211214
@"google.c.sender.id" : @123456789
212215
};
213-
[_mockExtensionHelper exportDeliveryMetricsToBigQueryWithMessageInfo:fakeMessageInfo];
214216
OCMReject([_mockExtensionHelper bundleIdentifierByRemovingLastPartFrom:[OCMArg any]]);
217+
[_mockExtensionHelper exportDeliveryMetricsToBigQueryWithMessageInfo:fakeMessageInfo];
218+
OCMVerifyAll(_mockExtensionHelper);
215219
}
216220

217221
@end

0 commit comments

Comments
 (0)