Skip to content

Commit 6673bf9

Browse files
committed
expecting build failure
1 parent a1da3f2 commit 6673bf9

File tree

2 files changed

+7
-9
lines changed

2 files changed

+7
-9
lines changed

.github/workflows/abtesting.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,8 @@ jobs:
4646
setup_command: scripts/setup_quickstart.sh abtesting
4747
plist_src_path: scripts/gha-encrypted/qs-database.plist.gpg
4848
plist_dst_path: quickstart-ios/database/GoogleService-Info.plist
49+
# secrets:
50+
# plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
4951

5052
# quickstart-ftl-cron-only:
5153
# # Don't run on private repo.

.github/workflows/common_quickstart.yml

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@ on:
2323
# secrets:
2424
# plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
2525
#
26-
# secrets:
27-
# plist_secret:
28-
# required: false
26+
secrets:
27+
plist_secret:
28+
required: true
2929

3030
inputs:
3131
# The product to test be tested (e.g. `FirebaseABTesting`).
@@ -66,7 +66,7 @@ jobs:
6666
# Run on the main repo's scheduled jobs or pull requests and manual workflow invocations.
6767
if: (github.repository == 'firebase/firebase-ios-sdk' && github.event_name == 'schedule') || contains(fromJSON('["pull_request", "workflow_dispatch"]'), github.event_name)
6868
env:
69-
plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
69+
plist_secret: ${{ secrets.plist_secret }}
7070
runs-on: macos-15
7171
steps:
7272
- uses: actions/checkout@v4
@@ -91,15 +91,11 @@ jobs:
9191
timeout_minutes: 15
9292
max_attempts: 3
9393
retry_wait_seconds: 120
94-
command: |
95-
([ -z $plist_secret ] || scripts/test_quickstart.sh ${{ inputs.product }} true)
94+
command: scripts/test_quickstart.sh ${{ inputs.product }} true
9695
# TODO: Add upload on fialure.
9796
# - name: Upload raw logs if failed.
9897
# if: ${{ failure() }}
9998
# uses: actions/upload-artifact@v4
10099
# with:
101100
# name:
102101
# path:
103-
104-
105-

0 commit comments

Comments
 (0)