Append framework name to Carthage plist bundleID (#5302)

ryanwilson · web-flow · commit ee5f8a37f429 · 2020-04-08T12:41:11.000-04:00
Addresses a symptom of #5299
diff --git a/ZipBuilder/Sources/ZipBuilder/CarthageUtils.swift b/ZipBuilder/Sources/ZipBuilder/CarthageUtils.swift
@@ -249,7 +249,7 @@ extension CarthageUtils {
   }
 
   static func generatePlistContents(forName name: String) -> Data {
-    let plist: [String: String] = ["CFBundleIdentifier": "com.firebase.Firebase",
+    let plist: [String: String] = ["CFBundleIdentifier": "com.firebase.Firebase-\(name)",
                                    "CFBundleInfoDictionaryVersion": "6.0",
                                    "CFBundlePackageType": "FMWK",
                                    "CFBundleVersion": "1",

Original file line number	Diff line number	Diff line change
`@@ -249,7 +249,7 @@ extension CarthageUtils {`
`249`	`249`	`}`
`250`	`250`
`251`	`251`	`static func generatePlistContents(forName name: String) -> Data {`
`252`		`- let plist: [String: String] = ["CFBundleIdentifier": "com.firebase.Firebase",`
	`252`	`+ let plist: [String: String] = ["CFBundleIdentifier": "com.firebase.Firebase-\(name)",`
`253`	`253`	`"CFBundleInfoDictionaryVersion": "6.0",`
`254`	`254`	`"CFBundlePackageType": "FMWK",`
`255`	`255`	`"CFBundleVersion": "1",`