Passkey Support #12733
Draft
Passkey Support #12733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Passkey #1 cloned] start passkey enrollment rpc (#11872) 1. implemented rpc call to startPasskeyEnrollment 2. defined startPasskeyEnrollment request and response 3. added unit tests [Passkey #2] finalize passkey enrollment rpc (#11885) Implemented finalizePasskeyEnrollment rpc call Defined finalizePasskeyEnrollment Request and Response object Added unit tests [passkey #3] startPasskeySignIn RPC call (#11889) Implemented start passkey sign in rpc call Defined startPasskeySignInRequest & Response Added Unit tests [Passkey #4] finalizePasskeySignIn rpc (#11904) 1. Implemented passkey finalize sign in rpc call 2. Defined finalizePasskeySignIn request & response 3. Added unit tests. [Passkey #5] Auth startPasskeySignInWithCompletion: and finalizePasskeySignInWithPlatformCredential:completion (#11952) [Passkey #6] Update passkey related proto naming change (#11953) [Passkey #7] FIRUser startPasskeyEnrollmentWithName:completion: & finalizePasskeyEnrollmentWithPlatformCredential:completion: implementation (#11991) [Passkey #8] Added enrolledPasskeys support on getAccountInfo rpc (#12002) [Passkey #9] Passkey withdraw (#12127)
Generated by 🚫 Danger |
Apple API Diff ReportCommit: 1949880 FirebaseAuthClassesFIRUser[ADDED] -finalizePasskeyEnrollmentWithPlatformCredential:completion:Swift:
+ func finalizePasskeyEnrollment ( with platformCredential : ASAuthorizationPlatformPublicKeyCredentialRegistration ) async throws -> AuthDataResult
Objective-C:
+ - ( void ) finalizePasskeyEnrollmentWithPlatformCredential : ( nonnull ASAuthorizationPlatformPublicKeyCredentialRegistration * ) platformCredential completion : ( nullable void ( ^ )( FIRAuthDataResult * _Nullable , NSError * _Nullable )) completion ;[ADDED] -startPasskeyEnrollmentWithName:completion:Swift:
+ func startPasskeyEnrollment ( with name : String ?) async throws -> ASAuthorizationPlatformPublicKeyCredentialRegistrationRequest
Objective-C:
+ - ( void ) startPasskeyEnrollmentWithName :( nullable NSString * ) name completion : ( nullable void ( ^ )( ASAuthorizationPlatformPublicKeyCredentialRegistrationRequest * _Nullable , NSError * _Nullable )) completion ;[ADDED] enrolledPasskeysSwift:
+ var enrolledPasskeys : [ PasskeyInfo ] { get }
Objective-C:
+ @property ( nonatomic , readonly ) API_UNAVAILABLE ( watchos ) NSArray < FIRPasskeyInfo *> * enrolledPasskeys ;[ADDED] -unenrollPasskeyWithCredentialID:completion:Swift:
+ func unenrollPasskey ( with credentialID : String ) async throws
Objective-C:
+ - ( void ) unenrollPasskeyWithCredentialID :( nonnull NSString * ) credentialID completion :( nullable void ( ^ )( NSError * _Nullable )) completion ;FIRAuth[ADDED] -startPasskeySignInWithCompletion:Swift:
+ func startPasskeySignIn () async throws -> ASAuthorizationPlatformPublicKeyCredentialAssertionRequest
Objective-C:
+ - ( void ) startPasskeySignInWithCompletion : ( nullable void ( ^ )( ASAuthorizationPlatformPublicKeyCredentialAssertionRequest * _Nullable , NSError * _Nullable )) completion ;[ADDED] -finalizePasskeySignInWithPlatformCredential:completion:Swift:
+ func finalizePasskeySignIn ( with platformCredential : ASAuthorizationPlatformPublicKeyCredentialAssertion ) async throws -> FIRAuthDataResult
Objective-C:
+ - ( void ) finalizePasskeySignInWithPlatformCredential : ( nonnull ASAuthorizationPlatformPublicKeyCredentialAssertion * ) platformCredential completion : ( nullable void ( ^ )( FIRAuthDataResult * _Nullable , NSError * _Nullable )) completion ;[ADDED] FIRPasskeyInfo[ADDED] FIRPasskeyInfoSwift:
+ class PasskeyInfo : NSObject
+ var name : String { get }
+ var credentialID : String { get }
Objective-C:
+ @interface FIRPasskeyInfo : NSObject
+ @property ( nonatomic , readonly ) NSString * _Nonnull name ;
+ @property ( nonatomic , readonly ) NSString * _Nonnull credentialID ;EnumerationsFIRAuthErrorCode[ADDED] FIRAuthErrorCodePasskeyEnrollmentNotFoundSwift:
+ case passkeyEnrollmentNotFound = 17209
Objective-C:
+ FIRAuthErrorCodePasskeyEnrollmentNotFound = 17209 |
Coverage Report 1Affected Products
Test Logs |
Xiaoshouzi-gh
commented
Apr 9, 2024
| @brief start sign in with passkey retrieving challenge from GCIP and create an assertion request. | ||
| @param completion Optionally; a block which creates a assertation request. | ||
| @remarks // TODO @liubinj add possible error codes |
There was a problem hiding this comment.
this is a fast follow up after private preview. Let me know if you think it's better to remove it for now @kevinthecheung
|
Hi @Xiaoshouzi-gh, any news on this? How can I help to land this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for TW review for private preview. We will not merge it to main branch.