Skip to content

Conversation

@milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Apr 19, 2024

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in a feature request so that we
    can discuss it together.

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link

google-oss-bot commented Apr 19, 2024

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestoreInternal.framework

    Overall coverage changed from 88.13% (3e872a3) to 88.17% (8781555) by +0.05%.

    FilenameBase (3e872a3)Merge (8781555)Diff
    exception.cc23.68%84.21%+60.53%
    leveldb_key.cc99.02%98.63%-0.39%
    leveldb_opener.cc78.99%77.54%-1.45%
    leveldb_remote_document_cache.cc96.55%94.83%-1.72%
    query.cc98.43%98.31%-0.12%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/hToZASWRz5.html

@milaGGL milaGGL closed this Oct 28, 2024
@firebase firebase locked and limited conversation to collaborators Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants