- 
                Notifications
    
You must be signed in to change notification settings  - Fork 1.7k
 
Adding Integration Test for Phone Number Authentication in Firebase #13538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
          
 Generated by 🚫 Danger  | 
    
| 
           LLC is missing. See other files in the repo or https://github.com/firebase/firebase-ios-sdk/blob/main/scripts/check_copyright.sh#L21  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on tests. The new file should be added to the SwiftApiTests target in the Xcode project so it builds and runs.
When I do that locally, it has some failures.
Also, it would be great to test the async variations of the APIs as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The check CI can be fixed by running:
scripts/style.sh FirebaseAuth/Tests/SampleSwift/SwiftApiTests/PhoneAuthTest.swift
You can also run it without args though, but I find it sometimes slows when it checks all the source. I like to run git diff --name-only main | xargs scripts/style.sh to style everything on my branch different from main.
        
          
                FirebaseAuth/Tests/SampleSwift/SwiftApiTests/PhoneAuthTest.swift
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                FirebaseAuth/Tests/SampleSwift/SwiftApiTests/PhoneAuthTest.swift
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                FirebaseAuth/Tests/SampleSwift/SwiftApiTests/PhoneAuthTest.swift
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                FirebaseAuth/Tests/SampleSwift/SwiftApiTests/PhoneAuthTest.swift
              
                Outdated
          
            Show resolved
            Hide resolved
        
      66252e9    to
    1dde83b      
    Compare
  
            
          
                FirebaseAuth/Tests/SampleSwift/AuthenticationExample.xcodeproj/project.pbxproj
          
            Show resolved
            Hide resolved
        
      There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the plist wasn't changed in this PR, I think it makes sense to revert all xcode proj changes that mention the plists
        
          
                FirebaseAuth/Tests/SampleSwift/AuthenticationExample.xcodeproj/project.pbxproj
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                FirebaseAuth/Tests/SampleSwift/AuthenticationExample.xcodeproj/project.pbxproj
          
            Show resolved
            Hide resolved
        
              
          
                FirebaseAuth/Tests/SampleSwift/AuthenticationExample.xcodeproj/project.pbxproj
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                FirebaseAuth/Tests/SampleSwift/AuthenticationExample.xcodeproj/project.pbxproj
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                FirebaseAuth/Tests/SampleSwift/AuthenticationExample.xcodeproj/project.pbxproj
          
            Show resolved
            Hide resolved
        
              
          
                FirebaseAuth/Tests/SampleSwift/AuthenticationExample.xcodeproj/project.pbxproj
          
            Show resolved
            Hide resolved
        
              
          
                FirebaseAuth/Tests/SampleSwift/AuthenticationExample.xcodeproj/project.pbxproj
          
            Show resolved
            Hide resolved
        
              
          
                FirebaseAuth/Tests/SampleSwift/AuthenticationExample.xcodeproj/project.pbxproj
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                FirebaseAuth/Tests/SampleSwift/AuthenticationExample.xcodeproj/project.pbxproj
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                FirebaseAuth/Tests/SampleSwift/AuthenticationExample.xcodeproj/project.pbxproj
              
                Outdated
          
            Show resolved
            Hide resolved
        
      Co-authored-by: Nick Cooke <[email protected]>
        
          
                FirebaseAuth/Tests/SampleSwift/AuthenticationExample.xcodeproj/project.pbxproj
              
                Outdated
          
            Show resolved
            Hide resolved
        
      Co-authored-by: Nick Cooke <[email protected]>
          
 confirmed they are building and running:  | 
    
          
 done  | 
    
        
          
                FirebaseAuth/Tests/SampleSwift/AuthenticationExample.xcodeproj/project.pbxproj
          
            Show resolved
            Hide resolved
        
      | 
           @srushtisv Any reason this code hasn't yet merged to main? Ideally, we should merge larger PRs to   | 
    
Implement integration test for verifying phone number sign-in with Firebase Auth. Please review and approve.