Skip to content

Added Marathi language in Remote Config Locale List #13597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 23, 2024
Merged

Added Marathi language in Remote Config Locale List #13597

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
01f4661
Added Marathi language code
rizafran Sep 5, 2024
ac0bef1
Added Marathi language
rizafran Sep 5, 2024
75e3236
Merge branch 'firebase:main' into rizafran-rclocalization
rizafran Sep 9, 2024
e107af4
Get list of language codes instead of hardcoded
rizafran Sep 11, 2024
4862a9d
Merge branch 'firebase:main' into rizafran-rclocalization
rizafran Oct 22, 2024
a3407c7
Revert changes. Added India language codes.
rizafran Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions FirebaseRemoteConfig/Sources/RCNDevice.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ RCNDeviceModel FIRRemoteConfigDeviceSubtype(void) {
return [[[NSLocale currentLocale] objectForKey:NSLocaleCountryCode] lowercaseString];
}

// TODO(rizafran): To migrate to use ISOLanguageCodes in the future
NSDictionary<NSString *, NSArray *> *FIRRemoteConfigFirebaseLocaleMap(void) {
return @{
// Albanian
Expand All @@ -82,8 +83,6 @@ RCNDeviceModel FIRRemoteConfigDeviceSubtype(void) {
@"fi" : @[ @"fi", @"fi_FI" ],
// Hebrew
@"he" : @[ @"he", @"iw_IL" ],
// Hindi
@"hi" : @[ @"hi_IN" ],
// Hungarian
@"hu" : @[ @"hu", @"hu_HU" ],
// Icelandic
Expand Down Expand Up @@ -153,6 +152,9 @@ RCNDeviceModel FIRRemoteConfigDeviceSubtype(void) {
@"de" : @[ @"de", @"de_AT", @"de_DE", @"de_LU", @"de_CH", @"de-DE" ],
// Greek
@"el" : @[ @"el", @"el_CY", @"el_GR" ],
// India
@"hi_IN" :
@[ @"hi_IN", @"ta_IN", @"te_IN", @"mr_IN", @"bn_IN", @"gu_IN", @"kn_IN", @"pa_Guru_IN" ],
// Italian
@"it" : @[ @"it", @"it_IT", @"it_CH", @"it-IT" ],
// Japanese
Expand Down Expand Up @@ -188,6 +190,7 @@ RCNDeviceModel FIRRemoteConfigDeviceSubtype(void) {
}
return locales;
}

NSString *FIRRemoteConfigDeviceLocale(void) {
NSArray<NSString *> *locales = FIRRemoteConfigAppManagerLocales();
NSArray<NSString *> *preferredLocalizations =
Expand Down
Loading