Skip to content

[Infra] Fix Swift 6 warning in FirebaseAppTests.swift #13627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 11, 2024
Merged

[Infra] Fix Swift 6 warning in FirebaseAppTests.swift #13627

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dab9f64
[Infra] Update FirebaseAppTests.swift
ncooke3 Sep 11, 2024
39336e7
style?
ncooke3 Sep 11, 2024
f705172
refactor
ncooke3 Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions FirebaseCore/Tests/SwiftUnit/FirebaseAppTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,22 +340,20 @@ class FirebaseAppTests: XCTestCase {
// MARK: - Helpers

private func expectAppConfigurationNotification(appName: String, isDefaultApp: Bool) {
let expectedUserInfo: NSDictionary = [
let expectedUserInfo: [String: Any] = [
"FIRAppNameKey": appName,
"FIRAppIsDefaultAppKey": NSNumber(value: isDefaultApp),
"FIRGoogleAppIDKey": Constants.Options.googleAppID,
]

expectation(forNotification: NSNotification.Name.firAppReadyToConfigureSDK,
object: FirebaseApp.self, handler: { notification -> Bool in
if let userInfo = notification.userInfo {
if expectedUserInfo.isEqual(to: userInfo) {
return true
}
} else {
guard let userInfo = notification.userInfo else {
XCTFail("Failed to unwrap notification user info")
return false
}
return false
return NSDictionary(dictionary: expectedUserInfo) ==
NSDictionary(dictionary: userInfo)
})
}
}
Loading