Skip to content

[Core] Add ability to load version from product SDK #13639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 19, 2024
Merged

[Core] Add ability to load version from product SDK #13639

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61aa419
[Core] Add ability to load version from product SDK
ncooke3 Sep 13, 2024
163fbc0
Update for FDC
ncooke3 Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion FirebaseCore/Sources/FIRApp.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -821,11 +821,24 @@ + (void)registerSwiftComponents {
@"FIRFunctions" : @"fire-fun",
@"FIRStorage" : @"fire-str",
@"FIRVertexAIComponent" : @"fire-vertex",
@"FIRFooComponent" : @"fire-foo",
};
for (NSString *className in swiftLibraries.allKeys) {
Class klass = NSClassFromString(className);
if (klass) {
[FIRApp registerLibrary:swiftLibraries[className] withVersion:FIRFirebaseVersion()];
NSString *version = FIRFirebaseVersion();
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wundeclared-selector"
SEL sdkVersionSelector = @selector(sdkVersion);
#pragma clang diagnostic pop
if ([klass respondsToSelector:sdkVersionSelector]) {
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Warc-performSelector-leaks"
NSString *sdkVersion = (NSString *)[klass performSelector:sdkVersionSelector];
if (sdkVersion) version = sdkVersion;
#pragma clang diagnostic pop
}
[FIRApp registerLibrary:swiftLibraries[className] withVersion:version];
}
}
}
Expand Down
Loading