[Vertex AI] Remove SafetyFeedback struct
#13666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paulb777 Should this have a changelog entry? Although it was completely useless it was a public struct. |
paulb777
approved these changes
Sep 18, 2024
SGTM
I noticed earlier with Nick's PR that it did work on re-run (seems to be running here now too) so the GHA failures are intermittent. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the
SafetyFeedbackstruct from the Vertex AI SDK since it isn't used anywhere. This also means thatSafetyRating.HarmProbability,SafetySettingandSafetySetting.BlockThresholdand no longer need to beCodablesince they are exclusively used for request (Encodable) or response (Decodable) types.#no-changelog