Skip to content

[Vertex AI] Remove unspecified enum cases from response types #13699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 23, 2024
Merged

[Vertex AI] Remove unspecified enum cases from response types #13699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
23ddaa2
[Vertex AI] Remove `unspecified` enum cases from response types
andrewheard Sep 23, 2024
a902ffd
Fix sample app
andrewheard Sep 23, 2024
5b67e1e
Add CHANGELOG entry
andrewheard Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions FirebaseVertexAI/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
removed. (#13686)
- [changed] **Breaking Change**: The `BlockThreshold` enum in `SafetySetting`
has been renamed to `HarmBlockThreshold`. (#13696)
- [changed] **Breaking Change**: The `unspecified` case has been removed from
the `FinishReason`, `PromptFeedback` and `HarmProbability` enums; this
scenario is now handled by the existing `unknown` case. (#13699)

# 11.3.0
- [added] Added `Decodable` conformance for `FunctionResponse`. (#13606)
Expand Down
1 change: 0 additions & 1 deletion FirebaseVertexAI/Sample/ChatSample/Views/ErrorDetailsView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ extension SafetyRating.HarmProbability: CustomStringConvertible {
case .medium: "Medium"
case .negligible: "Negligible"
case .unknown: "Unknown"
case .unspecified: "Unspecified"
}
}
}
Expand Down
6 changes: 1 addition & 5 deletions FirebaseVertexAI/Sources/GenerateContentResponse.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,10 +138,9 @@ public struct Citation: Sendable {
/// A value enumerating possible reasons for a model to terminate a content generation request.
@available(iOS 15.0, macOS 11.0, macCatalyst 15.0, tvOS 15.0, watchOS 8.0, *)
public enum FinishReason: String, Sendable {
/// The finish reason is unknown.
case unknown = "FINISH_REASON_UNKNOWN"

case unspecified = "FINISH_REASON_UNSPECIFIED"

/// Natural stop point of the model or provided stop sequence.
case stop = "STOP"

Expand All @@ -168,9 +167,6 @@ public struct PromptFeedback: Sendable {
/// The block reason is unknown.
case unknown = "UNKNOWN"

/// The block reason was not specified in the server response.
case unspecified = "BLOCK_REASON_UNSPECIFIED"

/// The prompt was blocked because it was deemed unsafe.
case safety = "SAFETY"

Expand Down
3 changes: 0 additions & 3 deletions FirebaseVertexAI/Sources/Safety.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,6 @@ public struct SafetyRating: Equatable, Hashable, Sendable {
/// Unknown. A new server value that isn't recognized by the SDK.
case unknown = "UNKNOWN"

/// The probability was not specified in the server response.
case unspecified = "HARM_PROBABILITY_UNSPECIFIED"

/// The probability is zero or close to zero. For benign content, the probability across all
/// categories will be this value.
case negligible = "NEGLIGIBLE"
Expand Down
Loading