Skip to content

Enhance FirebaseAuthCode quality #13751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Enhance FirebaseAuthCode quality #13751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96f4694
fix: a typo in a test log
MojtabaHs Oct 1, 2024
57ece3a
docs: fix a typo in comments
MojtabaHs Oct 1, 2024
9baf107
fix a word
MojtabaHs Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion FirebaseAuth/Tests/SampleSwift/ObjCApiTests/FIRAuthApiTestsBase.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ - (void)signInAnonymously {
handler:^(NSError *error) {
if (error != nil) {
XCTFail(@"Failed to wait for expectations "
@"in anonymousy sign in. Error: %@",
@"in anonymously sign in. Error: %@",
error.localizedDescription);
}
}];
Expand Down
2 changes: 1 addition & 1 deletion FirebaseAuth/Tests/Unit/GetProjectConfigTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ class GetProjectConfigTests: RPCBaseTests {
)
}

/** @fn testSuccessFulGetProjectConfigRequest
/** @fn testSuccessfulGetProjectConfigRequest
@brief This test checks for a successful response
*/
func testSuccessfulGetProjectConfigRequest() async throws {
Expand Down
2 changes: 1 addition & 1 deletion FirebaseAuth/Tests/Unit/RPCBaseTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ class RPCBaseTests: XCTestCase {
}

/** @fn checkBackendError
@brief This test checks error messagess from the backend map to the expected error codes
@brief This test checks error messages from the backend map to the expected error codes
*/
func checkBackendError(request: any AuthRPCRequest,
message: String = "",
Expand Down
Loading