Refactored Duplicate Methods in Functions
#13771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncooke3
reviewed
Oct 2, 2024
* Combined the two nearly identical `Functions.callFunction(…)` methods into one * Updated `Functions.urlWithName(_:)` to return an actual `URL`; renamed the method to `functionURL(for:)` * Refactored `HTTPSCallable` to store a function’s actual URL * Removed `HTTPSCallable.EndpointType` * Updated tests
yakovmanshin
force-pushed
the
functions-endpoint
branch
from
61e7982 to
d2ff0dd
Compare
yakovmanshin
changed the title
Functions.EndpointFunctions
ncooke3
approved these changes
Oct 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions.callFunction(…)methods into oneFunctions.urlWithName(_:)to return an actualURL; renamed the method tofunctionURL(for:)HTTPSCallableto store a function’s actual URLHTTPSCallable.EndpointType