Fix Performance Unit Tests requiring Unswizzling #13791
Open
+6
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just one test failure |
themiswang
approved these changes
Oct 3, 2024
visumickey
reviewed
Oct 3, 2024
|
I'm not comfortable with this PR. Without unswizzling, the tests will not be accurate. The host app would not be reset across every test. So, if one test does swizzling and if it fails to unswizzle - then the rest of the tests would run on a swizzled app which might not build confidence on the rest of the tests. So, we should not remove the unswizzling capability from tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are tests that supposedly require unswizzling, but when I remove the assertion, they all pass. There doesn't seem to be any issues removing all unswizzling from the unit tests.
#no-changelog