Skip to content

Fix a private runtime property name in FirebaseInAppMessaging #13798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Fix a private runtime property name in FirebaseInAppMessaging #13798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion FirebaseInAppMessaging/Sources/Flows/FIRIAMFetchFlow.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ - (void)checkAndFetchForInitialAppLaunch:(BOOL)forInitialAppLaunch {
if (sdkMode == FIRIAMSDKModeNewlyInstalled || sdkMode == FIRIAMSDKModeTesting) {
FIRLogDebug(kFIRLoggerInAppMessaging, @"I-IAM700007",
@"OK to fetch due to current SDK mode being %@",
FIRIAMDescriptonStringForSDKMode(sdkMode));
FIRIAMDescriptionStringForSDKMode(sdkMode));
fetchIsAllowedNow = YES;
} else {
FIRLogDebug(kFIRLoggerInAppMessaging, @"I-IAM700008",
Expand Down
2 changes: 1 addition & 1 deletion FirebaseInAppMessaging/Sources/Private/Runtime/FIRIAMSDKModeManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ typedef NS_ENUM(NSInteger, FIRIAMSDKMode) {
};

// turn the sdk mode enum integer value into a descriptive string
NSString *FIRIAMDescriptonStringForSDKMode(FIRIAMSDKMode mode);
NSString *FIRIAMDescriptionStringForSDKMode(FIRIAMSDKMode mode);

extern NSString *const kFIRIAMUserDefaultKeyForSDKMode;
extern NSString *const kFIRIAMUserDefaultKeyForServerFetchCount;
Expand Down
4 changes: 2 additions & 2 deletions FirebaseInAppMessaging/Sources/Runtime/FIRIAMSDKModeManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
#import "FirebaseInAppMessaging/Sources/FIRCore+InAppMessaging.h"
#import "FirebaseInAppMessaging/Sources/Private/Runtime/FIRIAMSDKModeManager.h"

NSString *FIRIAMDescriptonStringForSDKMode(FIRIAMSDKMode mode) {
NSString *FIRIAMDescriptionStringForSDKMode(FIRIAMSDKMode mode) {
switch (mode) {
case FIRIAMSDKModeTesting:
return @"Testing Instance";
Expand Down Expand Up @@ -76,7 +76,7 @@ - (instancetype)initWithUserDefaults:(GULUserDefaults *)userDefaults

FIRLogDebug(kFIRLoggerInAppMessaging, @"I-IAM290001",
@"SDK is in mode of %@ and has seen %d fetches.",
FIRIAMDescriptonStringForSDKMode(_sdkMode), (int)_fetchCount);
FIRIAMDescriptionStringForSDKMode(_sdkMode), (int)_fetchCount);
}
return self;
}
Expand Down
Loading