Skip to content

Fix: static constant name in FirebaseInAppMessaging runtimes #13799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Fix: static constant name in FirebaseInAppMessaging runtimes #13799

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions FirebaseInAppMessaging/Sources/Runtime/FIRIAMRuntimeManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ @interface FIRIAMRuntimeManager () <FIRIAMTestingModeListener>
@property(nonatomic, nonnull) FIRIAMFetchResponseParser *responseParser;
@end

static NSString *const _userDefaultsKeyForFIAMProgammaticAutoDataCollectionSetting =
static NSString *const _userDefaultsKeyForFIAMProgrammaticAutoDataCollectionSetting =
@"firebase-iam-sdk-auto-data-collection";

@implementation FIRIAMRuntimeManager {
Expand Down Expand Up @@ -97,7 +97,7 @@ - (void)testingModeSwitchedOn {

- (FIRIAMAutoDataCollectionSetting)FIAMProgrammaticAutoDataCollectionSetting {
id settingEntry = [[GULUserDefaults standardUserDefaults]
objectForKey:_userDefaultsKeyForFIAMProgammaticAutoDataCollectionSetting];
objectForKey:_userDefaultsKeyForFIAMProgrammaticAutoDataCollectionSetting];

if (![settingEntry isKindOfClass:[NSNumber class]]) {
FIRLogDebug(kFIRLoggerInAppMessaging, @"I-IAM180014",
Expand Down Expand Up @@ -192,7 +192,7 @@ - (void)resume {
// persist the setting
[[GULUserDefaults standardUserDefaults]
setObject:@(YES)
forKey:_userDefaultsKeyForFIAMProgammaticAutoDataCollectionSetting];
forKey:_userDefaultsKeyForFIAMProgrammaticAutoDataCollectionSetting];

@synchronized(self) {
if (!_running) {
Expand All @@ -213,7 +213,7 @@ - (void)pause {
// persist the setting
[[GULUserDefaults standardUserDefaults]
setObject:@(NO)
forKey:_userDefaultsKeyForFIAMProgammaticAutoDataCollectionSetting];
forKey:_userDefaultsKeyForFIAMProgrammaticAutoDataCollectionSetting];

@synchronized(self) {
if (_running) {
Expand Down
Loading