Skip to content

Docs: enhance FirebaseMessaging token sources comments #13805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Docs: enhance FirebaseMessaging token sources comments #13805

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions FirebaseMessaging/Sources/Token/FIRMessagingTokenManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -744,15 +744,15 @@ - (void)setAPNSToken:(NSData *)APNSToken withUserInfo:(NSDictionary *)userInfo {
handler:^(NSString *_Nullable token,
NSError *_Nullable error){
// Do nothing as callback is not needed and the
// sub-funciton already handle errors.
// sub-function already handle errors.
}];
}
if ([self->_tokenStore cachedTokenInfos].count == 0) {
[self tokenWithAuthorizedEntity:self.fcmSenderID
scope:kFIRMessagingDefaultTokenScope
options:tokenOptions
handler:^(NSString *_Nullable FCMToken, NSError *_Nullable error){
// Do nothing as callback is not needed and the sub-funciton
// Do nothing as callback is not needed and the sub-function
// already handle errors.
}];
}
Expand Down
Loading