Skip to content

Fix: FirebasePerformance TestApp log messages in the source code #13822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2024
Merged

Fix: FirebasePerformance TestApp log messages in the source code #13822

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions FirebasePerformance/Tests/TestApp/Source/ViewControllers/NetworkConnectionViewController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ - (void)networkConnectionViewDidTapRequestButton:(NetworkConnectionView *)connec
PerfLog(@"Start perform network request");
[self.connection
makeNetworkRequestWithSuccessCallback:^{
PerfLog(@"Network operation complited with success");
PerfLog(@"Network operation completed with success");
dispatch_async(dispatch_get_main_queue(), ^{
[weakSelf updateUIForOperationCompleted];
weakSelf.connectionView.progressViewColor = [UIColor greenColor];
Expand All @@ -155,7 +155,7 @@ - (void)networkConnectionViewDidTapRequestButton:(NetworkConnectionView *)connec
}
failureCallback:^(NSError *error) {
dispatch_async(dispatch_get_main_queue(), ^{
PerfLog(@"Network operation complited with fail: %@", error.localizedDescription);
PerfLog(@"Network operation completed with fail: %@", error.localizedDescription);
[weakSelf updateUIForOperationCompleted];
weakSelf.connectionView.progressViewColor = [UIColor redColor];
self.connectionView.connectionStatus = ConnectionStatus_Fail;
Expand Down
Loading