Skip to content

[Auth] Fix crash when using TOTP MFA auth #13880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2024
Merged

[Auth] Fix crash when using TOTP MFA auth #13880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
264161e
[Auth] Fix crash when using TOTP MFA auth
ncooke3 Oct 11, 2024
fc1c4c7
Add changelog entry
ncooke3 Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions FirebaseAuth/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# 11.4.0
- [Fixed] Restore Firebase 10 behavior by ignoring `nil` display names used
during multi factor enrollment. (#13856)
- [Fixed] Fix crash when enrolling account with TOTP MFA. (#13880)

# 11.3.0
- [Fixed] Restore Firebase 10 behavior by querying with the
Expand Down
1 change: 1 addition & 0 deletions FirebaseAuth/Sources/Swift/MultiFactor/MultiFactor.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ import Foundation
}
}
}
return
} else if assertion.factorID != PhoneMultiFactorInfo.PhoneMultiFactorID {
return
}
Expand Down
Loading