Skip to content

Conversation

srushtisv
Copy link
Contributor

test to verify email link sent successfully

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@srushtisv srushtisv requested review from ncooke3 and removed request for Xiaoshouzi-gh and pashanka October 21, 2024 17:01
@ncooke3
Copy link
Member

ncooke3 commented Oct 21, 2024

clang-format versions disappear from homebrew every few months. main should always be fixed, but branches off of main like this one may stop working until they are synced with main again

Copy link
Contributor

@Xiaoshouzi-gh Xiaoshouzi-gh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also add a custom domain test? The custom domain for CI projects should be "firebaseiosauthsample.testdomaindonotuse.com"

Copy link
Contributor

@Xiaoshouzi-gh Xiaoshouzi-gh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The base branch fdl-dep has rebased from main by a force push.
If the CI did not reflect please try following steps:

  1. squash all our commits in fdl-dep-test into 1 commit (note down the hash)
    You can do this by git reset --soft to the last commit that is not yours then do a git commit.
  2. clone a new branch base of fdl-dep
  3. cherry-pick the commit from step 1 to 2.

@srushtisv
Copy link
Contributor Author

completed in #140000

@srushtisv srushtisv closed this Nov 4, 2024
@firebase firebase locked and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants