-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix: correct LocalizedError
conformance
#13895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct LocalizedError
conformance
#13895
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Thanks @vvisionnn! Please sign the CLA and someone will review this PR. |
@vvisionnn Thanks. It looks like the change leads to several CI errors that will need to be investigated. |
FirebaseCore/Internal/Sources/HeartbeatLogging/RingBuffer.swift
Outdated
Show resolved
Hide resolved
CI should be fixable by running scripts/style.sh FirebaseCore/Internal/Sources/HeartbeatLogging/RingBuffer.swift |
@ncooke3 I have executed this script after I mentioned this error, but there is nothing changed, don't know why |
checked the script, looks like it is just a |
based on the document of

LocalizedError
here: https://developer.apple.com/documentation/foundation/localizederror/2946895-errordescriptionthe
errorDescription
is a optional string type, the original implementation just using the fallback of the default protocol conformance