Skip to content

Conversation

vvisionnn
Copy link
Contributor

based on the document of LocalizedError here: https://developer.apple.com/documentation/foundation/localizederror/2946895-errordescription
Screenshot 2024-10-16 at 12 38 29 AM

the errorDescription is a optional string type, the original implementation just using the fallback of the default protocol conformance

Copy link

google-cla bot commented Oct 15, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@morganchen12
Copy link
Contributor

Thanks @vvisionnn! Please sign the CLA and someone will review this PR.

@paulb777
Copy link
Member

@vvisionnn Thanks. It looks like the change leads to several CI errors that will need to be investigated.

@ncooke3
Copy link
Member

ncooke3 commented Oct 16, 2024

CI should be fixable by running

scripts/style.sh FirebaseCore/Internal/Sources/HeartbeatLogging/RingBuffer.swift

@vvisionnn
Copy link
Contributor Author

@ncooke3 I have executed this script after I mentioned this error, but there is nothing changed, don't know why

@vvisionnn
Copy link
Contributor Author

checked the script, looks like it is just a swiftformat command with config file at root level
just run format manually

@paulb777 paulb777 merged commit c249369 into firebase:main Oct 17, 2024
57 checks passed
@firebase firebase locked and limited conversation to collaborators Nov 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants