Skip to content

[Config] Mark two RCNConfigSettings properties atomic #13925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 18, 2024
Merged

[Config] Mark two RCNConfigSettings properties atomic #13925

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c5a26da
[Config] Mark two 'RCNConfigSettings' properties atomic
ncooke3 Oct 17, 2024
4ffd061
Add changelog entry
ncooke3 Oct 17, 2024
83e910e
Apply suggestions from code review
ncooke3 Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions FirebaseRemoteConfig/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# Unreleased
- [fixed] Mark two internal properties as `atomic` to prevent concurrency
related crash. (#13898)

# 11.0.0
- [fixed] RemoteConfigValue stringValue is now `nonnull`. This may break some builds. (#10870)
- [removed] **Breaking change**: The deprecated `FirebaseRemoteConfigSwift`
Expand Down
6 changes: 4 additions & 2 deletions FirebaseRemoteConfig/Sources/Private/RCNConfigSettings.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,11 @@
/// Device data version of checkin information.
@property(nonatomic, copy) NSString *deviceDataVersion;
/// InstallationsID.
@property(nonatomic, copy) NSString *configInstallationsIdentifier;
/// @note The property is atomic because it is access across multiple threads.
@property(atomic, copy) NSString *configInstallationsIdentifier;
/// Installations token.
@property(nonatomic, copy) NSString *configInstallationsToken;
/// @note The property is atomic because it is access across multiple threads.
@property(atomic, copy) NSString *configInstallationsToken;

/// A list of successful fetch timestamps in milliseconds.
/// TODO Not used anymore. Safe to remove.
Expand Down
Loading