Skip to content

[CoreExtension] Remove NS_SWIFT_UNAVAILABLE attribute that caused breaking change #13942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 21, 2024
Merged

[CoreExtension] Remove NS_SWIFT_UNAVAILABLE attribute that caused breaking change #13942

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8a1a62e
[CoreExtension] Remove NS_SWIFT_UNAVAILABLE attrbiute that caused bre…
ncooke3 Oct 21, 2024
938f0c5
Bump pods depending on this header
ncooke3 Oct 21, 2024
1444c5e
Fix firebase.podspec
ncooke3 Oct 21, 2024
7082e91
Bump FirebaseCore's dep on FirebaseCoreInternal
ncooke3 Oct 21, 2024
a1f59b5
Bump FirebaseCoreExtension's dep on FirebaseCore
ncooke3 Oct 21, 2024
75136bd
Bump FirebaseCoreExtension's dep on FirebaseCore (better way)
ncooke3 Oct 21, 2024
c85fe0a
changelog
ncooke3 Oct 21, 2024
78844ff
review
ncooke3 Oct 21, 2024
c591763
Revert bump
ncooke3 Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Firebase.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = 'Firebase'
s.version = '11.4.0'
s.version = '11.4.1'
s.summary = 'Firebase'

s.description = <<-DESC
Expand Down Expand Up @@ -43,7 +43,7 @@ Simplify your app development, grow your user base, and monetize more effectivel
end

s.subspec 'CoreOnly' do |ss|
ss.dependency 'FirebaseCore', '11.4.0'
ss.dependency 'FirebaseCore', '11.4.1'
ss.source_files = 'CoreOnly/Sources/Firebase.h'
ss.preserve_paths = 'CoreOnly/Sources/module.modulemap'
if ENV['FIREBASE_POD_REPO_FOR_DEV_POD'] then
Expand Down
4 changes: 2 additions & 2 deletions FirebaseCore.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = 'FirebaseCore'
s.version = '11.4.0'
s.version = '11.4.1'
s.summary = 'Firebase Core'

s.description = <<-DESC
Expand Down Expand Up @@ -53,7 +53,7 @@ Firebase Core includes FIRApp and FIROptions which provide central configuration
# Remember to also update version in `cmake/external/GoogleUtilities.cmake`
s.dependency 'GoogleUtilities/Environment', '~> 8.0'
s.dependency 'GoogleUtilities/Logger', '~> 8.0'
s.dependency 'FirebaseCoreInternal', '~> 11.0'
s.dependency 'FirebaseCoreInternal', '~> 11.4'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FirebaseCoreInternal added API in 11.4 that FirebaseCore depends on so FirebaseCore's dependency on FirebaseCoreInternal needs to be updated like this.


s.pod_target_xcconfig = {
'GCC_C_LANGUAGE_STANDARD' => 'c99',
Expand Down
4 changes: 4 additions & 0 deletions FirebaseCore/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# Firebase 11.4.1
- [fixed] CocoaPods only release to revert breaking change in
`FirebaseCoreExtension` SDK. (https://github.com/firebase/flutterfire/issues/13527)

# Firebase 11.4.0
- [fixed] Fixed issue building documentation with some Firebase products. (#13756)

Expand Down
3 changes: 1 addition & 2 deletions FirebaseCore/Extension/FIRHeartbeatLogger.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,7 @@ typedef NS_ENUM(NSInteger, FIRDailyHeartbeatCode) {
API_AVAILABLE(ios(13.0), macosx(10.15), macCatalyst(13.0), tvos(13.0), watchos(6.0));

/// Return the header value for the heartbeat logger.
- (NSString *_Nullable)
headerValue NS_SWIFT_UNAVAILABLE("Use `asyncHeaderValue() async -> String?` instead.");
- (NSString *_Nullable)headerValue;
#endif // FIREBASE_BUILD_CMAKE

@end
Expand Down
4 changes: 2 additions & 2 deletions FirebaseCoreExtension.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = 'FirebaseCoreExtension'
s.version = '11.4.0'
s.version = '11.4.1'
s.summary = 'Extended FirebaseCore APIs for Firebase product SDKs'

s.description = <<-DESC
Expand Down Expand Up @@ -34,5 +34,5 @@ Pod::Spec.new do |s|
"#{s.module_name}_Privacy" => 'FirebaseCore/Extension/Resources/PrivacyInfo.xcprivacy'
}

s.dependency 'FirebaseCore', '~> 11.0'
s.dependency 'FirebaseCore', '>= 11.4.1', '< 12.0'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because FirebaseCoreExtension depends on FirebaseCore yet shares the same headers in its sources, they should be versioned together whenever these headers change.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so how do i apply this now to my pod or code

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jenkinsernest, I added a comment for you over in firebase/flutterfire#13527 (comment)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok thanks

Copy link
Member Author

@ncooke3 ncooke3 Oct 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewheard , going to revert this because it will make 11.4.1 incompatible with Firebase Core 11.2, which then will require a Flutter update to pick up the fixed FirebaseCoreExtension.

end
Loading