Skip to content

[Core] Fix iOS 12 spec lint failure from incomplete FirebaseCoreInternal implementation #13952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Oct 22, 2024
Merged

[Core] Fix iOS 12 spec lint failure from incomplete FirebaseCoreInternal implementation #13952

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
2907dbc
[Core] Add availability gate on implementation
ncooke3 Oct 22, 2024
3e9c506
Add changelog entry
ncooke3 Oct 22, 2024
e4af499
bump specs
ncooke3 Oct 22, 2024
73cb34f
undo bump in extension pod
ncooke3 Oct 22, 2024
7db9bdd
Runtime approach
ncooke3 Oct 22, 2024
cde104d
Move issue down into FirebaseCoreInternal
ncooke3 Oct 22, 2024
94bb5ee
Revert "Runtime approach"
ncooke3 Oct 22, 2024
4fbdbce
[skip ci] review
ncooke3 Oct 22, 2024
a2c8aae
[skip ci] review: changelog
ncooke3 Oct 22, 2024
1a5827b
Bump FirebaseCoreInternal
ncooke3 Oct 22, 2024
5e6b55d
Bump core's dep on coreinternal
ncooke3 Oct 22, 2024
13affce
Add TODO
ncooke3 Oct 22, 2024
4e9c6dd
Fix auth test build failure from global test run
ncooke3 Oct 22, 2024
181c7c8
[Core] Prefer completion handler APIs in Core Internal (#13954)
ncooke3 Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions FirebaseCore/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# Firebase 11.4.2
- [fixed] CocoaPods only release to fix iOS 12 build failure resulting from
missing OS availability check in the `FirebaseCoreExtension` SDK.

# Firebase 11.4.1
- [fixed] CocoaPods only release to revert breaking change in
`FirebaseCoreExtension` SDK. (#13942)
Expand Down
3 changes: 2 additions & 1 deletion FirebaseCore/Sources/FIRHeartbeatLogger.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,8 @@ - (FIRHeartbeatsPayload *)flushHeartbeatsIntoPayload {
}

- (void)flushHeartbeatsIntoPayloadWithCompletionHandler:
(void (^)(FIRHeartbeatsPayload *))completionHandler {
(void (^)(FIRHeartbeatsPayload *))completionHandler
API_AVAILABLE(ios(13.0), macosx(10.15), macCatalyst(13.0), tvos(13.0), watchos(6.0)) {
[_heartbeatController flushAsyncWithCompletionHandler:^(FIRHeartbeatsPayload *payload) {
completionHandler(payload);
}];
Expand Down
Loading