Skip to content

Conversation

@andrewheard
Copy link
Contributor

@andrewheard andrewheard commented Oct 23, 2024

  • Added a test app to host Vertex AI in Firebase integration tests.
    • This approach provides keychain access, which allows us to use App Check with the Debug Provider.
  • Added tests to check the Firebase Auth / Storage integration.

#no-changelog

@andrewheard andrewheard marked this pull request as ready for review October 25, 2024 21:36
@andrewheard andrewheard requested a review from paulb777 October 25, 2024 21:37
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

My only concern is that I don't see any tests in the log at https://github.com/firebase/firebase-ios-sdk/actions/runs/11525405469/job/32088217991

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the minimum iOS version needs to be set on the xcodebuild command?

@andrewheard
Copy link
Contributor Author

My only concern is that I don't see any tests in the log at firebase/firebase-ios-sdk/actions/runs/11525405469/job/32088217991

Interestingly it only seems to produce output when I intentionally make the tests fail (e.g., this previous run). I was also able to see the calls to App Check in the Firebase Console for this CI run (they now show verified).

Maybe the minimum iOS version needs to be set on the xcodebuild command?

I'll dig into why the tests aren't listed one by one when they succeed in a follow-up PR. I'll also drop the deployment target to iOS 15 (it's unnecessarily high at 17.2 -- I forgot to change the default in the new Xcode project).

@andrewheard andrewheard merged commit 1077879 into main Oct 25, 2024
64 checks passed
@andrewheard andrewheard deleted the ah/vertex-test-app branch October 25, 2024 22:29
@firebase firebase locked and limited conversation to collaborators Nov 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants