Skip to content

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Nov 6, 2024

#no-changelog

@paulb777
Copy link
Member

paulb777 commented Nov 6, 2024

Looks like a missing CI trigger.

Good idea, but I think this will be a problem for incremental unit testing with the ObjC tests.

@ncooke3 ncooke3 requested a review from paulb777 November 6, 2024 19:27
@ncooke3
Copy link
Member Author

ncooke3 commented Nov 6, 2024

It looks like the interop layer is able to map set {} to the synthesized setter. The Obj-C tests run:

Screenshot 2024-11-06 at 2 30 04 PM

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ncooke3 ncooke3 requested a review from andrewheard November 6, 2024 20:46
@ncooke3 ncooke3 merged commit 8cf2e02 into rc-swift Nov 6, 2024
29 checks passed
@ncooke3 ncooke3 deleted the nc/rc-swift-1 branch November 6, 2024 20:50
@firebase firebase locked and limited conversation to collaborators Dec 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants