Skip to content

[Auth] Mark *Credential classes as Sendable #14100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2024
Merged

[Auth] Mark *Credential classes as Sendable #14100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion FirebaseAuth/Sources/Swift/AuthProvider/AuthCredential.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import Foundation

/// Public representation of a credential.
@available(iOS 13, tvOS 13, macOS 10.15, macCatalyst 13, watchOS 7, *)
@objc(FIRAuthCredential) open class AuthCredential: NSObject {
@objc(FIRAuthCredential) open class AuthCredential: NSObject, @unchecked Sendable {
/// The name of the identity provider for the credential.
@objc public let provider: String

Expand Down
3 changes: 2 additions & 1 deletion FirebaseAuth/Sources/Swift/AuthProvider/EmailAuthProvider.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ import Foundation
}

@available(iOS 13, tvOS 13, macOS 10.15, macCatalyst 13, watchOS 7, *)
@objc(FIREmailPasswordAuthCredential) class EmailAuthCredential: AuthCredential, NSSecureCoding {
@objc(FIREmailPasswordAuthCredential) class EmailAuthCredential: AuthCredential, NSSecureCoding,
@unchecked Sendable {
let email: String

enum EmailType {
Expand Down
3 changes: 2 additions & 1 deletion FirebaseAuth/Sources/Swift/AuthProvider/FacebookAuthProvider.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ import Foundation
}

@available(iOS 13, tvOS 13, macOS 10.15, macCatalyst 13, watchOS 7, *)
@objc(FIRFacebookAuthCredential) class FacebookAuthCredential: AuthCredential, NSSecureCoding {
@objc(FIRFacebookAuthCredential) class FacebookAuthCredential: AuthCredential, NSSecureCoding,
@unchecked Sendable {
let accessToken: String

init(withAccessToken accessToken: String) {
Expand Down
2 changes: 1 addition & 1 deletion FirebaseAuth/Sources/Swift/AuthProvider/GameCenterAuthProvider.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@

@available(iOS 13, tvOS 13, macOS 10.15, macCatalyst 13, watchOS 7, *)
@objc(FIRGameCenterAuthCredential)
class GameCenterAuthCredential: AuthCredential, NSSecureCoding {
class GameCenterAuthCredential: AuthCredential, NSSecureCoding, @unchecked Sendable {
let playerID: String
let teamPlayerID: String?
let gamePlayerID: String?
Expand Down
3 changes: 2 additions & 1 deletion FirebaseAuth/Sources/Swift/AuthProvider/GitHubAuthProvider.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ import Foundation
}

@available(iOS 13, tvOS 13, macOS 10.15, macCatalyst 13, watchOS 7, *)
@objc(FIRGitHubAuthCredential) class GitHubAuthCredential: AuthCredential, NSSecureCoding {
@objc(FIRGitHubAuthCredential) class GitHubAuthCredential: AuthCredential, NSSecureCoding,
@unchecked Sendable {
let token: String

init(withToken token: String) {
Expand Down
3 changes: 2 additions & 1 deletion FirebaseAuth/Sources/Swift/AuthProvider/GoogleAuthProvider.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ import Foundation
}

@available(iOS 13, tvOS 13, macOS 10.15, macCatalyst 13, watchOS 7, *)
@objc(FIRGoogleAuthCredential) class GoogleAuthCredential: AuthCredential, NSSecureCoding {
@objc(FIRGoogleAuthCredential) class GoogleAuthCredential: AuthCredential, NSSecureCoding,
@unchecked Sendable {
let idToken: String
let accessToken: String

Expand Down
3 changes: 2 additions & 1 deletion FirebaseAuth/Sources/Swift/AuthProvider/OAuthCredential.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ import Foundation

/// Internal implementation of `AuthCredential` for generic credentials.
@available(iOS 13, tvOS 13, macOS 10.15, macCatalyst 13, watchOS 7, *)
@objc(FIROAuthCredential) open class OAuthCredential: AuthCredential, NSSecureCoding {
@objc(FIROAuthCredential) open class OAuthCredential: AuthCredential, NSSecureCoding,
@unchecked Sendable {
/// The ID Token associated with this credential.
@objc(IDToken) public let idToken: String?

Expand Down
3 changes: 2 additions & 1 deletion FirebaseAuth/Sources/Swift/AuthProvider/PhoneAuthCredential.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ import Foundation
///
/// This class is available on iOS only.
@available(iOS 13, tvOS 13, macOS 10.15, macCatalyst 13, watchOS 7, *)
@objc(FIRPhoneAuthCredential) open class PhoneAuthCredential: AuthCredential, NSSecureCoding {
@objc(FIRPhoneAuthCredential) open class PhoneAuthCredential: AuthCredential, NSSecureCoding,
@unchecked Sendable {
enum CredentialKind {
case phoneNumber(_ phoneNumber: String, _ temporaryProof: String)
case verification(_ id: String, _ code: String)
Expand Down
3 changes: 2 additions & 1 deletion FirebaseAuth/Sources/Swift/AuthProvider/TwitterAuthProvider.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ import Foundation
}

@available(iOS 13, tvOS 13, macOS 10.15, macCatalyst 13, watchOS 7, *)
@objc(FIRTwitterAuthCredential) class TwitterAuthCredential: AuthCredential, NSSecureCoding {
@objc(FIRTwitterAuthCredential) class TwitterAuthCredential: AuthCredential, NSSecureCoding,
@unchecked Sendable {
let token: String
let secret: String

Expand Down
2 changes: 1 addition & 1 deletion FirebaseAuth/Sources/Swift/Utilities/AuthRecaptchaVerifier.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
}

@available(iOS 13, tvOS 13, macOS 10.15, macCatalyst 13, watchOS 7, *)
class AuthRecaptchaVerifier {
class AuthRecaptchaVerifier: @unchecked Sendable {
private(set) weak var auth: Auth?
private(set) var agentConfig: AuthRecaptchaConfig?
private(set) var tenantConfigs: [String: AuthRecaptchaConfig] = [:]
Expand Down
Loading