Skip to content

[Firestore] Add conditonal Sendability conformance to ServerTimestamp #14162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 22, 2024
Merged

[Firestore] Add conditonal Sendability conformance to ServerTimestamp #14162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a4a74e
[Auth] Add conditonal Sendability conformance to ServerTimestamp
ncooke3 Nov 21, 2024
6d4a23a
[skip ci] changelog entry
ncooke3 Nov 22, 2024
5f2c549
restart CI
ncooke3 Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Firestore/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# Unreleased
- [fixed] Add conditional `Sendable` conformance so `ServerTimestamp<T>` is
`Sendable` if `T` is `Sendable`. (#14042)

# 11.4.0
- [changed] Prepare Firestore cache to support session token.

Expand Down
2 changes: 2 additions & 0 deletions Firestore/Swift/Source/Codable/ServerTimestamp.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,3 +105,5 @@ public struct ServerTimestamp<Value>: Codable
extension ServerTimestamp: Equatable where Value: Equatable {}

extension ServerTimestamp: Hashable where Value: Hashable {}

extension ServerTimestamp: Sendable where Value: Sendable {}
Loading