[Auth] Add objc attribute to UserInfoImpl so legacy decoding works #14169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncooke3
commented
Nov 25, 2024
paulb777
approved these changes
Nov 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class names was changed from
FIRUserInfoImpltoUserInfoImpl, but the unarchiving older copies (pre name change) requires knowing the original ObjC name. The rest of the direct/transitive types from theUserclass'sinit?(coder:)look okay.We actually do this for other classes, I just had to make the connection that the class wasn't being decoded because the pre-11 archive didn't have a blob mapping to "UserInfoImpl". The blob was mapping to "FIRUserInfoImpl".
firebase-ios-sdk/FirebaseAuth/Sources/Swift/SystemService/AuthAppCredential.swift
Lines 18 to 19 in 700fd68
Fix #14011