Skip to content

Update the method documentation of recordError #14198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 5, 2024
Merged

Update the method documentation of recordError #14198

merged 3 commits into from
Dec 5, 2024

Conversation

tejasd
Copy link
Contributor

@tejasd tejasd commented Dec 2, 2024 •
edited
Loading

Update the documentation on the recordError:userInfo method.

#no-changelog

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@ncooke3 ncooke3 assigned ncooke3 and unassigned ncooke3 Dec 3, 2024
@ncooke3 ncooke3 self-requested a review December 3, 2024 18:52
@tejasd tejasd changed the title Update the comment about recordError Update the method documentation of recordError Dec 4, 2024
@tejasd
Copy link
Contributor Author

tejasd commented Dec 5, 2024

I confirmed this behaviour w/ test crashes and non fatals - http://shortn/_H1HqlaxRFj

@tejasd tejasd marked this pull request as ready for review December 5, 2024 20:08
@tejasd tejasd requested review from mrober and themiswang December 5, 2024 20:09
@tejasd tejasd merged commit 16381c7 into main Dec 5, 2024
53 checks passed
@tejasd tejasd deleted the td/record-error branch December 5, 2024 20:51
@firebase firebase locked and limited conversation to collaborators Jan 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mrober mrober mrober approved these changes

@ncooke3 ncooke3 Awaiting requested review from ncooke3

@themiswang themiswang Awaiting requested review from themiswang

Assignees

No one assigned

Labels

api: crashlytics public-api-change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tejasd @google-oss-bot @mrober @ncooke3