[Auth] Swift 6 improvements for AuthRecaptchaVerifier
#14240
+105
−124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
ncooke3
force-pushed
the
nc/recaptcha-improvements
branch
from
71f50a1 to
1fe3323
Compare
This reverts commit b70ebdb.
ncooke3
commented
Feb 18, 2025
Comment on lines
-79
to
-86
| class func shared(auth: Auth?) -> AuthRecaptchaVerifier { | ||
| if _shared.auth != auth { | ||
| _shared.agentConfig = nil | ||
| _shared.tenantConfigs = [:] | ||
| _shared.auth = auth | ||
| } | ||
| return _shared | ||
| } |
There was a problem hiding this comment.
With the sample app, I tried the following using the current code (red diff):
- initialize recaptcha (success)
- switch to configured secondary app
- initialize recaptcha (threw internal error)
I tried these steps again with the new code, and I got the same result.
paulb777
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.