Skip to content

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Dec 10, 2024

Manual tests:

  • Phone MFA login
  • TOTP MFA login

#no-changelog

@ncooke3 ncooke3 marked this pull request as ready for review January 4, 2025 00:50
@ncooke3 ncooke3 added this to the 11.7.0 - M158 milestone Jan 4, 2025
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider my comments optional, since this is already a good step forward.

@ncooke3
Copy link
Member Author

ncooke3 commented Jan 6, 2025

Great ideas, thanks @paulb777. I have a note in my Firebase 12 API improvements doc about improving the MFA API with an enum or similar to make switching over MFA types easier.

@ncooke3 ncooke3 merged commit c092c02 into main Jan 6, 2025
55 checks passed
@ncooke3 ncooke3 deleted the nc/multifactor-refactor branch January 6, 2025 17:20
@firebase firebase locked and limited conversation to collaborators Feb 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants