[rc-swift] RemoteConfigValue

[paulb777]

Perhaps the most notable thing about this transition is needing to make a few items public for the FirebasePerformance internal dependency since we can no longer rely upon internal Objective-C headers.

#no-changelog

[github-actions]

Apple API Diff Report

Commit: 8c951b5
Last updated: Thu Dec 12 10:54 PST 2024
View workflow logs & download artifacts

---

FirebaseRemoteConfig

Classes

[REMOVED] FIRRemoteConfigValue

[REMOVED] FIRRemoteConfigValue

Swift:
-    var stringValue : String { get }
-    var numberValue : NSNumber { get }
-    var dataValue : Data { get }
-    var boolValue : Bool { get }
-    var jsonValue : Any ? { get }
-    var source : RemoteConfigSource { get }
-    init ( data : Data ?, source : RemoteConfigSource )
Objective-C:
-    @property ( nonatomic , readonly , nonnull ) NSString * stringValue ;
-    @property ( nonatomic , readonly , nonnull ) NSNumber * numberValue ;
-    @property ( nonatomic , readonly , nonnull ) NSData * dataValue ;
-    @property ( nonatomic , readonly ) BOOL boolValue ;
-    @property ( nonatomic , readonly , nullable ) id JSONValue ;
-    @property ( nonatomic , readonly ) FIRRemoteConfigSource source ;
-    - ( instancetype _Nonnull ) initWithData :( nullable NSData * ) data source :( FIRRemoteConfigSource ) source ;

FIRRemoteConfig

[MODIFIED] -defaultValueForKey:

Swift:
+  func defaultValue ( forKey key : String ?) -> FIRRemoteConfigValue ?
-  func defaultValue ( forKey key : String ?) -> RemoteConfigValue ?
Objective-C:
+  - ( nullable FIRRemoteConfigValue * ) defaultValueForKey :( nullable NSString * ) key ;
-  - ( nullable FIRRemoteConfigValue * ) defaultValueForKey :( nullable NSString * ) key ;

[MODIFIED] -configValueForKey:

Swift:
+  func configValue ( forKey key : String ?) -> FIRRemoteConfigValue
-  func configValue ( forKey key : String ?) -> RemoteConfigValue
Objective-C:
+  - ( nonnull FIRRemoteConfigValue * ) configValueForKey :( nullable NSString * ) key ;
-  - ( nonnull FIRRemoteConfigValue * ) configValueForKey :( nullable NSString * ) key ;

[MODIFIED] -configValueForKey:source:

Swift:
+  func configValue ( forKey key : String ?, source : RemoteConfigSource ) -> FIRRemoteConfigValue
-  func configValue ( forKey key : String ?, source : RemoteConfigSource ) -> RemoteConfigValue
Objective-C:
+  - ( nonnull FIRRemoteConfigValue * ) configValueForKey :( nullable NSString * ) key source : ( FIRRemoteConfigSource ) source ;
-  - ( nonnull FIRRemoteConfigValue * ) configValueForKey :( nullable NSString * ) key source : ( FIRRemoteConfigSource ) source ;

[MODIFIED] -objectForKeyedSubscript:

Swift:
+  subscript ( key : String ) -> FIRRemoteConfigValue { get }
-  subscript ( key : String ) -> RemoteConfigValue { get }
Objective-C:
+  - ( nonnull FIRRemoteConfigValue * ) objectForKeyedSubscript : ( nonnull NSString * ) key ;
-  - ( nonnull FIRRemoteConfigValue * ) objectForKeyedSubscript : ( nonnull NSString * ) key ;

---

[paulb777]

Test failures are flakes/expected. pod-gen unit tests are running locally

[ncooke3]

Nothing important to address, LGTM!

[ncooke3]

Suggested change

	@import FirebaseRemoteConfig;

[paulb777]

Thanks for the thoughtful review!

[ncooke3]

There is still one small behavior difference. If a non-nil, empty data object was used in ObjC, it would make it past the nil check and try to serialize. I just tested what happens when you serialize an empty data object and you get an error (Error Domain=NSCocoaErrorDomain Code=3840 "Unable to parse empty data." UserInfo={NSDebugDescription=Unable to parse empty data.}).

So the net difference is that non-nil empty data would exit with nil here, while ObjC implementation would throw and catch the serialization error, log the message, and return nil. Removing line 54-56 would match ObjC implementation. The main difference is that the early exit here misses the log message.