Skip to content

Add a test for comparing cross type numbers #14283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
milaGGL wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Add a test for comparing cross type numbers #14283

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
190d706
add test
milaGGL Dec 23, 2024
5303d84
format
milaGGL Dec 23, 2024
b9859dc
Update FIRQueryTests.mm
milaGGL Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions Firestore/Example/Tests/Integration/API/FIRQueryTests.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -896,6 +896,30 @@ - (void)testSdkOrdersQueryByDocumentIdTheSameWayOnlineAndOffline {
]];
}

- (void)testSnapshotListenerSortsNumbersSameWayAsServer {
FIRCollectionReference *collRef = [self collectionRefWithDocuments:@{
@"intMin" : @{@"value" : @LLONG_MIN},
@"doubleMin" : @{@"value" : @((double)LLONG_MIN - 100)},
@"intMax" : @{@"value" : @LLONG_MAX},
@"doubleMax" : @{@"value" : @((double)LLONG_MAX + 100)},
@"NaN" : @{@"value" : [NSNumber numberWithFloat:NAN]},
@"integerMax" : @{@"value" : @(INT_MAX)},
@"integerMin" : @{@"value" : @(INT_MIN)},
@"negativeInfinity" : @{@"value" : @(-INFINITY)},
@"positiveInfinity" : @{@"value" : @(INFINITY)}
}];

FIRQuery *query = [collRef queryOrderedByField:@"value"];
FIRQuerySnapshot *getSnapshot = [self readDocumentSetForRef:query];

id<FIRListenerRegistration> registration =
[query addSnapshotListener:self.eventAccumulator.valueEventHandler];
FIRQuerySnapshot *watchSnapshot = [self.eventAccumulator awaitEventWithName:@"Snapshot"];
XCTAssertEqualObjects(FIRQuerySnapshotGetIDs(watchSnapshot), FIRQuerySnapshotGetIDs(getSnapshot));

[registration remove];
}

- (void)testCollectionGroupQueriesWithWhereFiltersOnArbitraryDocumentIDs {
// Use .document() to get a random collection group name to use but ensure it starts with 'b'
// for predictable ordering.
Expand Down
Loading