Skip to content

Conversation

ehsannas
Copy link
Contributor

Upgrade the gRPC version to pick up the fix mentioned in #14323 (comment)

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cherylEnkidu @ncooke3 The binary distribution will also need to be updated before the next release.

@ehsannas ehsannas changed the title Update to gRPC 1.66.0 Update to gRPC 1.69.0 Jan 21, 2025
@ehsannas
Copy link
Contributor Author

ehsannas commented Feb 3, 2025

@paulb777 @cherylEnkidu After firebase/abseil-cpp-SwiftPM#25 was merged, the abseil issue is resolved for this PR and the bots pass. We should be good to merge this PR. PTAL

packageInfo = ("https://github.com/grpc/grpc-ios.git", "1.65.0" ..< "1.66.0")
packageInfo = ("https://github.com/grpc/grpc-ios.git", "1.69.0" ..< "1.70.0")
} else {
packageInfo = ("https://github.com/google/grpc-binary.git", "1.65.1" ..< "1.66.0")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be updated in a follow-up PR. Please coordinate with @ncooke3 to do so.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SG

@ehsannas ehsannas merged commit 49831bf into main Feb 3, 2025
48 checks passed
@ehsannas ehsannas deleted the ehsann/upgrade-grpc branch February 3, 2025 20:34
@firebase firebase locked and limited conversation to collaborators Mar 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants