Skip to content

[Crashlytics] enhance inline documentations #14413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 2, 2025
Merged

[Crashlytics] enhance inline documentations #14413

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c429c2
docs: fix a typo of `explanation` word
MojtabaHs Feb 2, 2025
1332fcb
docs: fix a typo of `memory` word
MojtabaHs Feb 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Crashlytics/Crashlytics/Models/Record/FIRCLSReportAdapter.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,8 +257,8 @@ - (google_crashlytics_Platforms)protoPlatformFromString:(NSString *)str {
*/
pb_bytes_array_t *FIRCLSEncodeData(NSData *data) {
// We have received couple security tickets before for using calloc here.
// Here is a short explaination on how it is calculated so buffer overflow is prevented:
// We will alloc an amount of memeory for struct `pb_bytes_array_t`, this struct contains two
// Here is a short explanation on how it is calculated so buffer overflow is prevented:
// We will alloc an amount of memory for struct `pb_bytes_array_t`, this struct contains two
// attributes:
// pb_size_t size
// pb_byte_t bytes[1]
Expand All @@ -268,7 +268,7 @@ - (google_crashlytics_Platforms)protoPlatformFromString:(NSString *)str {
// For size, NSData return size in `unsigned long` type which is the same size as `pb_size_t` and
// it is declared in compile time depending on the arch of system. If overflow happened it should
// happend at NSData level first when user trying to inserting data to NSData.
// For bytes, it is just a strict memeory copy of the data in NSData.
// For bytes, it is just a strict memory copy of the data in NSData.
// The whole structure will be freed as a part of process for deallocing report in dealloc() of
// this class
pb_bytes_array_t *pbBytes = calloc(1, PB_BYTES_ARRAY_T_ALLOCSIZE(data.length));
Expand Down
Loading