Restore socket rocket #14427
Merged
Restore socket rocket #14427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewheard
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
LGTM.
Without looking at how involved it would be, something we could also consider in the future would be updating our copy of SocketRocket. It seems there was very little activity in the repo between 2015 and 2021 and then they started releasing again: https://github.com/facebookincubator/SocketRocket/releases
morganchen12
approved these changes
Feb 5, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix connection failure issue introduced in 10.27.0 by restoring the Socket Rocket implementation instead of
NSURLSessionWebSocket.Note that this may expose a Thread Performance Checker Warning (#12883)
Fixes #14188, #13877, #13855, #13529