Streamable functions - Change "stream()" signature. #14497
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add two tests to cover new API Add enum to handle response from stream Add extension to Callable for Streamable Content.
Add Enum to switch over response type Add New test to match new API design doc.
Add TODO note.
Accepted suggestion. Co-authored-by: Nick Cooke <[email protected]>
Accepted suggestion. Co-authored-by: Nick Cooke <[email protected]>
Accepted suggestion Co-authored-by: Nick Cooke <[email protected]>
Add placeholders so we can pass CI, while we finalize stream() functionality
Change Request to Request? = nil. Add Test case to cover no arguments in call.
ncooke3
reviewed
Feb 25, 2025
Accepted suggestion. Co-authored-by: Nick Cooke <[email protected]>
ncooke3
reviewed
Feb 25, 2025
ncooke3
reviewed
Feb 25, 2025
ncooke3
reviewed
Feb 25, 2025
Accepted suggestion. Co-authored-by: Nick Cooke <[email protected]>
Accepted suggestion. Co-authored-by: Nick Cooke <[email protected]>
Co-authored-by: Nick Cooke <[email protected]>
ncooke3
reviewed
Feb 25, 2025
Revert TODO for XCTFail
…rebase-ios-sdk into streamable-functions
ncooke3
reviewed
Feb 25, 2025
Co-authored-by: Nick Cooke <[email protected]>
Co-authored-by: Nick Cooke <[email protected]>
Co-authored-by: Nick Cooke <[email protected]>
Co-authored-by: Nick Cooke <[email protected]>
Co-authored-by: Nick Cooke <[email protected]>
ncooke3
reviewed
Feb 25, 2025
Co-authored-by: Nick Cooke <[email protected]>
Co-authored-by: Nick Cooke <[email protected]>
Co-authored-by: Nick Cooke <[email protected]>
ncooke3
reviewed
Feb 25, 2025
Co-authored-by: Nick Cooke <[email protected]>
ncooke3
reviewed
Feb 25, 2025
Co-authored-by: Nick Cooke <[email protected]>
ncooke3
reviewed
Feb 25, 2025
ncooke3
reviewed
Feb 25, 2025
…rebase-ios-sdk into streamable-functions
…rebase-ios-sdk into streamable-functions
Sync to head and add tests to an extension.
ncooke3
reviewed
Feb 26, 2025
| // TODO: Ensure decoding failures are passed into reasonable errors. | ||
| @available(macOS 12.0, iOS 15.0, watchOS 8.0, tvOS 15.0, *) | ||
| func stream(_ data: Request) -> AsyncThrowingStream<Response, Error> { | ||
| func stream(_ data: Request? = nil) -> AsyncThrowingStream<Response, Error> { |
There was a problem hiding this comment.
Could you revert the changes in the file apart from this line?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Request?=nil
Add new test for no args are passed.