[Swift 6] Address low-hanging Swift concurrency errors in Functions #14597
Conversation
@available(iOS 13, macCatalyst 13, macOS 10.15, tvOS 13, watchOS 7, *) func context(options: HTTPSCallableOptions?) async throws -> FunctionsContext { async let authToken = auth?.getToken(forcingRefresh: false) async let appCheckToken = getAppCheckToken(options: options) // Sending 'options' risks causing data races async let limitedUseAppCheckToken = getLimitedUseAppCheckToken(options: options)
@available(iOS 13, macCatalyst 13, macOS 10.15, tvOS 13, watchOS 7, *) func context(options: HTTPSCallableOptions?) async throws -> FunctionsContext { async let authToken = auth?.getToken(forcingRefresh: false) // 💥 Sending 'self' risks causing data races async let appCheckToken = getAppCheckToken(options: options) // 💥 Sending 'self' risks causing data races async let limitedUseAppCheckToken = getLimitedUseAppCheckToken(options: options) // 💥 Sending 'self' risks causing data races
struct FunctionsError: CustomNSError {
static let errorDomain = FunctionsErrorDomain
let code: FunctionsErrorCode // 💥 Stored property 'code' of 'Sendable'-conforming struct 'FunctionsError' has non-sendable type 'FunctionsErrorCode'
…ethod
// Handle the content and parse it.
let content = try callableStreamResult(fromResponseData: data, endpointURL: url)
continuation.yield(content) // 💥 Sending 'content' risks causing data races
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback. |
3 participants
Added to each commit message is the corresponding snippet of code that it fixed.
Recommend ignoring whitespace: https://github.com/firebase/firebase-ios-sdk/pull/14597/files?diff=unified&w=1
#no-changelog