Skip to content

Fix %lx, %lu, %ld, %llx, %llu, %lld #14791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025
Merged

Fix %lx, %lu, %ld, %llx, %llu, %lld #14791

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion Crashlytics/Crashlytics/Helpers/FIRCLSInternalLogging.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,13 +83,29 @@ void FIRCLSSDKFileLog(FIRCLSInternalLogLevel level, const char* format, ...) {
if (!string) {
string = "(null)";
}

write(fd, string, strlen(string));
} break;
case 'x': {
unsigned int value = va_arg(args, unsigned int);
FIRCLSFileFDWriteUInt64(fd, value, true);
} break;
case 'l': {
// llx, llu, lld
if (idx + 1 < formatLength && format[idx + 1] == 'l') {
idx ++;
}

//lx, lu, ld
if (idx + 1 < formatLength) {
uint64_t value = va_arg(args, uint64_t);
if (format[idx + 1] == 'x') {
FIRCLSFileFDWriteUInt64(fd, value, true);
} else if (format[idx + 1] == 'd' || format[idx + 1] == 'u') {
FIRCLSFileFDWriteUInt64(fd, value, false);
}
idx ++;
}
} break;
default:
// unhandled, back up to write out the percent + the format char
write(fd, &format[idx - 1], 2);
Expand Down
Loading