Skip to content

[Firebase AI] Upload xcodebuild logs in integration tests #14844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 15, 2025
Merged

[Firebase AI] Upload xcodebuild logs in integration tests #14844

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
758579c
[Firebase AI] Upload `xcodebuild.log` in integration tests
andrewheard May 12, 2025
16ff991
Try `--preserve-unbeautified`
andrewheard May 12, 2025
c727e50
Split `xcodebuild build` and `xcodebuild test`
andrewheard May 14, 2025
8785f92
Upload both logs, make name unique, increase compression
andrewheard May 14, 2025
8db3a12
Update approach to get last arg
andrewheard May 14, 2025
aad2f3c
Update approach to get last arg again
andrewheard May 14, 2025
76a0d30
Upload only on failure
andrewheard May 14, 2025
7395532
Merge branch 'main' into ah/firebaseai-xcodebuild-log
andrewheard May 14, 2025
7a8bce6
Remove redundant `2>&1` from `tee` to `xcbeautify` pipe
andrewheard May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/firebaseai.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,13 @@ jobs:
run: sudo xcode-select -s /Applications/${{ matrix.xcode }}.app/Contents/Developer
- name: Run IntegrationTests
run: scripts/build.sh FirebaseAIIntegration ${{ matrix.target }}
- name: Upload xcodebuild logs
if: failure()
uses: actions/upload-artifact@v4
with:
name: xcodebuild-${{ matrix.target }}-${{ matrix.os }}-${{ matrix.xcode }}.log
path: xcodebuild-*.log
retention-days: 2

pod-lib-lint:
# Don't run on private repo unless it is a PR.
Expand Down
24 changes: 17 additions & 7 deletions scripts/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,12 +109,15 @@ source scripts/check_secrets.sh
# If xcodebuild fails with known error codes, retries once.
function RunXcodebuild() {
echo xcodebuild "$@"
local xcodebuild_args=("$@")
local buildaction="${xcodebuild_args[$# - 1]}" # buildaction is the last arg
local log_filename="xcodebuild-${buildaction}.log"

xcbeautify_cmd=(xcbeautify --renderer github-actions --disable-logging)
local xcbeautify_cmd=(xcbeautify --renderer github-actions --disable-logging)

result=0
xcodebuild "$@" | tee xcodebuild.log | "${xcbeautify_cmd[@]}" \
&& CheckUnexpectedFailures xcodebuild.log \
local result=0
NSUnbufferedIO=YES xcodebuild "$@" 2>&1 | tee "$log_filename" 2>&1 | \
"${xcbeautify_cmd[@]}" && CheckUnexpectedFailures "$log_filename" \
|| result=$?

if [[ $result == 65 ]]; then
Expand All @@ -124,8 +127,8 @@ function RunXcodebuild() {
sleep 5

result=0
xcodebuild "$@" | tee xcodebuild.log | "${xcbeautify_cmd[@]}" \
&& CheckUnexpectedFailures xcodebuild.log \
NSUnbufferedIO=YES xcodebuild "$@" 2>&1 | tee "$log_filename" 2>&1 | \
"${xcbeautify_cmd[@]}" && CheckUnexpectedFailures "$log_filename" \
|| result=$?
fi

Expand Down Expand Up @@ -505,12 +508,19 @@ case "$product-$platform-$method" in
;;

FirebaseAIIntegration-*-*)
# Build
RunXcodebuild \
-project 'FirebaseAI/Tests/TestApp/VertexAITestApp.xcodeproj' \
-scheme "VertexAITestApp-SPM" \
"${xcb_flags[@]}" \
build

# Run tests
RunXcodebuild \
-project 'FirebaseAI/Tests/TestApp/VertexAITestApp.xcodeproj' \
-scheme "VertexAITestApp-SPM" \
"${xcb_flags[@]}" \
-parallel-testing-enabled NO \
build \
test
;;

Expand Down
Loading