Skip to content

[Core] Deprecate '-[FIROptions deepLinkURLScheme]' API #15001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 18, 2025
Merged

[Core] Deprecate '-[FIROptions deepLinkURLScheme]' API #15001

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bfaa4b1
[Core] Deprecate '-[FIROptions deepLinkURLScheme]' API
ncooke3 Jun 18, 2025
ead8c45
use ivars to avoid triggering deprecation warning from getter
ncooke3 Jun 18, 2025
7a82d5c
Update FirebaseCore/Sources/FIROptions.m
ncooke3 Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions FirebaseCore/Sources/FIROptions.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ - (id)copyWithZone:(NSZone *)zone {
FIROptions *newOptions = [(FIROptions *)[[self class] allocWithZone:zone]
initInternalWithOptionsDictionary:self.optionsDictionary];
if (newOptions) {
newOptions.deepLinkURLScheme = self.deepLinkURLScheme;
newOptions->_deepLinkURLScheme = self->_deepLinkURLScheme;
newOptions.appGroupID = self.appGroupID;
newOptions.editingLocked = self.isEditingLocked;
newOptions.usingOptionsFromDefaultPlist = self.usingOptionsFromDefaultPlist;
Expand Down Expand Up @@ -357,8 +357,8 @@ - (BOOL)isEqualToOptions:(FIROptions *)options {

// Validate extra properties not contained in the dictionary. Only validate it if one of the
// objects has the property set.
if ((options.deepLinkURLScheme != nil || self.deepLinkURLScheme != nil) &&
![options.deepLinkURLScheme isEqualToString:self.deepLinkURLScheme]) {
if ((options->_deepLinkURLScheme != nil || self->_deepLinkURLScheme != nil) &&
![options->_deepLinkURLScheme isEqualToString:self->_deepLinkURLScheme]) {
return NO;
}

Expand All @@ -384,7 +384,7 @@ - (NSUInteger)hash {
// Note: `self.analyticsOptionsDictionary` was left out here since it solely relies on the
// contents of the main bundle's `Info.plist`. We should avoid reading that file and the contents
// should be identical.
return self.optionsDictionary.hash ^ self.deepLinkURLScheme.hash ^ self.appGroupID.hash;
return self->_deepLinkURLScheme.hash ^ self->_deepLinkURLScheme.hash ^ self.appGroupID.hash;
}

#pragma mark - Internal instance methods
Expand Down
2 changes: 1 addition & 1 deletion FirebaseCore/Sources/Public/FirebaseCore/FIROptions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ NS_SWIFT_NAME(FirebaseOptions)
/**
* The URL scheme used to set up Durable Deep Link service.
*/
@property(nonatomic, copy, nullable) NSString *deepLinkURLScheme;
@property(nonatomic, copy, nullable) NSString *deepLinkURLScheme DEPRECATED_ATTRIBUTE;

/**
* The Google Cloud Storage bucket name, e.g. @"abc-xyz-123.storage.firebase.com".
Expand Down
Loading