-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Adding Sample App Changes #15040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Parent:
Exchange token tests
Merged
Adding Sample App Changes #15040
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
90835dd
sample app implementation
srushtisv e0e7bdd
updating exchange token request and response file
srushtisv dcd2ddb
lint fix
srushtisv a17edfc
removing settings to resolve failing checks
srushtisv e2ad1b3
update AuthenticationExampleUITests
srushtisv a9f9b4c
Add Regionalized GCIP token-only session support via ExchangeToken (#…
srushtisv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,8 +14,8 @@ | |
|
|
||
| import Foundation | ||
|
|
||
| private let regionalGCIPAPIHost = "identityplatform.googleapis.com" | ||
| private let regionalGCIPStagingAPIHost = "staging-identityplatform.sandbox.googleapis.com" | ||
| private let kRegionalGCIPAPIHost = "identityplatform.googleapis.com" | ||
| private let kRegionalGCIPStagingAPIHost = "staging-identityplatform.sandbox.googleapis.com" | ||
|
|
||
| // MARK: - ExchangeTokenRequest | ||
|
|
||
|
|
@@ -44,14 +44,6 @@ struct ExchangeTokenRequest: AuthRPCRequest { | |
| /// Flag for whether to use the staging backend. | ||
| let useStaging: Bool | ||
|
|
||
| /// The base URL components for the request, will be used to construct the final URL. | ||
| private var baseURLComponents: URLComponents { | ||
| var components = URLComponents() | ||
| components.scheme = "https" | ||
| components.host = useStaging ? regionalGCIPStagingAPIHost : regionalGCIPAPIHost | ||
| return components | ||
| } | ||
|
|
||
| /// Initializes an `ExchangeTokenRequest`. | ||
| /// | ||
| /// - Parameters: | ||
|
|
@@ -89,16 +81,16 @@ struct ExchangeTokenRequest: AuthRPCRequest { | |
| "Internal Error: ExchangeTokenRequest requires `location`, `tenantId`, and `projectID`." | ||
| ) | ||
| } | ||
| var components = baseURLComponents | ||
| if location != "global" { | ||
| components.host = "\(location)-\(components.host ?? "")" | ||
| } | ||
| let locationPath = location == "global" ? "global" : location | ||
| components | ||
| .path = | ||
| "/v2beta/projects/\(project)/locations/\(locationPath)/tenants/\(tenant)/idpConfigs/\(idpConfigID):exchangeOidcToken" | ||
| components.queryItems = [URLQueryItem(name: "key", value: config.apiKey)] | ||
| guard let url = components.url else { | ||
| let baseHost = useStaging ? kRegionalGCIPStagingAPIHost : kRegionalGCIPAPIHost | ||
| let host = (location == "prod-global" || location == "global") ? baseHost : | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why is there |
||
| "\(location)-\(baseHost)" | ||
|
|
||
| let locationPath = (location == "prod-global") ? "global" : location | ||
|
|
||
| let path = "/v2beta/projects/\(project)/locations/\(locationPath)" + | ||
| "/tenants/\(tenant)/idpConfigs/\(idpConfigID):exchangeOidcToken" | ||
|
|
||
| guard let url = URL(string: "https://\(host)\(path)?key=\(config.apiKey)") else { | ||
| fatalError("Failed to create URL for ExchangeTokenRequest") | ||
| } | ||
| return url | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,8 +25,10 @@ class AppManager { | |
| private var otherApp: FirebaseApp | ||
| var app: FirebaseApp | ||
|
|
||
| // Initialise Auth with TenantConfig | ||
| let tenantConfig = Auth.TenantConfig(tenantId: "Foo-e2e-tenant-007", location: "global") | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. TenantConfig should be moved out of Auth namespace. |
||
| func auth() -> Auth { | ||
| return Auth.auth(app: app) | ||
| return Auth.auth(app: app, tenantConfig: tenantConfig) | ||
| } | ||
|
|
||
| private init() { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Prefer the non-prefixed versions for constants. The k prefix is more common in ObjC