Skip to content

Add FirebaseAIConfig support #15099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

Conversation

daymxn
Copy link
Member

@daymxn daymxn commented Jul 9, 2025

Per b/430576238,

This adds support for the FirebaseAIConfig struct, alongside the AppCheckOptions struct. The limitedUseTokens aspect is implemented, and has been documented as well.

Limited-use tokens have a shorter TTL than the standard app check tokens, which helps provide a smaller attack surface for malicious attackers. Limited-use tokens are also required to take advantage of replay protection, which Firebase AI Logic will support in the future. Since limited-use tokens are backwards compatible, we can add support on the client SDKs before the backend supports replay protection; this will allow consumers to adopt limited-use tokens early, and enable replay protection right away when it releases.

@daymxn daymxn requested a review from andrewheard July 9, 2025 17:16
@daymxn daymxn self-assigned this Jul 9, 2025
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

@daymxn daymxn requested a review from ncooke3 July 15, 2025 17:37
daymxn and others added 2 commits July 16, 2025 15:33
Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great doc comments! LGTM on green CI and resolution of error conversation.

Additionally, please add a very brief comment to the PR description about why limited tokens are added. This can be reused in changelog entry.

For a changelog entry, since the version is not finalized, # Unreleased can be used as the section header.

@ncooke3 ncooke3 self-requested a review August 13, 2025 16:39
daymxn and others added 3 commits August 13, 2025 16:02
daymxn and others added 2 commits August 13, 2025 16:34
Comment on lines +223 to +232
#if Debug
fatalError(errorMessage)
#else
throw NSError(
domain: "\(Constants.baseErrorDomain).\(Self.self)",
code: AILog.MessageCode.appCheckTokenFetchFailed.rawValue,
userInfo: [NSLocalizedDescriptionKey: errorMessage]
)
#endif
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know how this error gets wrapped by Firebase AI Logic? NSError is mainly for an Objective-C context. Is it easy to get the error message out if your at the top-level trying to parse the internal error?

cc: @andrewheard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants