-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add FirebaseAIConfig support #15099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add FirebaseAIConfig support #15099
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback. |
Co-authored-by: Nick Cooke <[email protected]>
Co-authored-by: Nick Cooke <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great doc comments! LGTM on green CI and resolution of error conversation.
Additionally, please add a very brief comment to the PR description about why limited tokens are added. This can be reused in changelog entry.
For a changelog entry, since the version is not finalized, # Unreleased
can be used as the section header.
Co-authored-by: Nick Cooke <[email protected]>
Co-authored-by: Nick Cooke <[email protected]>
Co-authored-by: Nick Cooke <[email protected]>
Co-authored-by: Nick Cooke <[email protected]>
…base/firebase-ios-sdk into daymxn-fal-limitedusetokens-support
Co-authored-by: Nick Cooke <[email protected]>
Co-authored-by: Nick Cooke <[email protected]>
Co-authored-by: Nick Cooke <[email protected]>
Co-authored-by: Nick Cooke <[email protected]>
Co-authored-by: Nick Cooke <[email protected]>
Co-authored-by: Nick Cooke <[email protected]>
#if Debug | ||
fatalError(errorMessage) | ||
#else | ||
throw NSError( | ||
domain: "\(Constants.baseErrorDomain).\(Self.self)", | ||
code: AILog.MessageCode.appCheckTokenFetchFailed.rawValue, | ||
userInfo: [NSLocalizedDescriptionKey: errorMessage] | ||
) | ||
#endif | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know how this error gets wrapped by Firebase AI Logic? NSError is mainly for an Objective-C context. Is it easy to get the error message out if your at the top-level trying to parse the internal error?
cc: @andrewheard
Per b/430576238,
This adds support for the
FirebaseAIConfig
struct, alongside theAppCheckOptions
struct. ThelimitedUseTokens
aspect is implemented, and has been documented as well.Limited-use tokens have a shorter TTL than the standard app check tokens, which helps provide a smaller attack surface for malicious attackers. Limited-use tokens are also required to take advantage of replay protection, which Firebase AI Logic will support in the future. Since limited-use tokens are backwards compatible, we can add support on the client SDKs before the backend supports replay protection; this will allow consumers to adopt limited-use tokens early, and enable replay protection right away when it releases.