Skip to content

[FirebaseMessaging] Fix Xcode 26 symbol crash #15165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 31, 2025
Merged

[FirebaseMessaging] Fix Xcode 26 symbol crash #15165

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7eb1bd7
[FirebaseMessaging] Fix crash on Xcode 26 + iOS 18 (#15164)
subdiox Jul 31, 2025
52957ce
changelog
ncooke3 Jul 31, 2025
044a244
style
ncooke3 Jul 31, 2025
d43fab9
Update CHANGELOG.md
ncooke3 Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions FirebaseInAppMessaging/Sources/Runtime/FIRIAMActionURLFollower.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,8 +175,9 @@ - (BOOL)followURLWithContinueUserActivity:(NSURL *)url {
FIRLogDebug(kFIRLoggerInAppMessaging, @"I-IAM240004",
@"App delegate responds to application:continueUserActivity:restorationHandler:."
"Simulating action url opening from a web browser.");
NSUserActivity *userActivity =
[[NSUserActivity alloc] initWithActivityType:NSUserActivityTypeBrowsingWeb];
// Use string literal to ensure compatibility with Xcode 26 and iOS 18
NSString *browsingWebType = @"NSUserActivityTypeBrowsingWeb";
NSUserActivity *userActivity = [[NSUserActivity alloc] initWithActivityType:browsingWebType];
userActivity.webpageURL = url;
BOOL handled = [self.appDelegate application:self.mainApplication
continueUserActivity:userActivity
Expand Down
5 changes: 3 additions & 2 deletions FirebaseInAppMessaging/Tests/Unit/FIRIAMActionUrlFollowerTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,9 @@ - (void)testUniversalLinkHandlingReturnYES {
continueUserActivity:[OCMArg checkWithBlock:^BOOL(id userActivity) {
// verifying the type and url field for the userActivity object
NSUserActivity *activity = (NSUserActivity *)userActivity;
return [activity.activityType
isEqualToString:NSUserActivityTypeBrowsingWeb] &&
// Use string literal to ensure compatibility with Xcode 26 and iOS 18
NSString *browsingWebType = @"NSUserActivityTypeBrowsingWeb";
return [activity.activityType isEqualToString:browsingWebType] &&
[activity.webpageURL isEqual:url];
}]
restorationHandler:[OCMArg any]])
Expand Down
4 changes: 4 additions & 0 deletions FirebaseMessaging/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# 12.1.0
- [fixed] Fix Xcode 26 crash from missing `NSUserActivityTypeBrowsingWeb`
symbol. The fix will apply to the Firebase.zip in the next release. (#15159)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix will apply to the Firebase.zip in the next release.

Is this the normal phrasing you guys use? Like initially I feel like this doesn't necessarily signal that the fix went out with everything besides the zip, but if this aligns with past phrasing then disregard.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me find what's been used in the past and use that here.


# 11.14.0
- [fixed] Fix a potential SQL injection issue. (#14846).

Expand Down
5 changes: 3 additions & 2 deletions FirebaseMessaging/Sources/FIRMessaging.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,8 +400,9 @@ - (void)handleIncomingLinkIfNeededFromMessage:(NSDictionary *)message {
// if they haven't implemented it.
if ([NSUserActivity class] != nil &&
[appDelegate respondsToSelector:continueUserActivitySelector]) {
NSUserActivity *userActivity =
[[NSUserActivity alloc] initWithActivityType:NSUserActivityTypeBrowsingWeb];
// Use string literal to ensure compatibility with Xcode 26 and iOS 18
NSString *browsingWebType = @"NSUserActivityTypeBrowsingWeb";
NSUserActivity *userActivity = [[NSUserActivity alloc] initWithActivityType:browsingWebType];
userActivity.webpageURL = url;
[appDelegate application:application
continueUserActivity:userActivity
Expand Down
Loading