Skip to content

fix(tooling): Use module name over spec name in XCFramework module maps #15229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2025
Merged

fix(tooling): Use module name over spec name in XCFramework module maps #15229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ReleaseTooling/Sources/ZipBuilder/FrameworkBuilder.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ struct FrameworkBuilder {
///
/// - Parameter framework: The name of the pod to be built.
/// - Returns: The corresponding framework/module name.
private static func frameworkBuildName(_ framework: String) -> String {
static func frameworkBuildName(_ framework: String) -> String {
switch framework {
case "abseil":
return "absl"
Expand Down
7 changes: 6 additions & 1 deletion ReleaseTooling/Sources/ZipBuilder/ModuleMapBuilder.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,11 @@ struct ModuleMapBuilder {
installedPods[name]?.transitiveFrameworks = transitiveFrameworkDeps
installedPods[name]?.transitiveLibraries = transitiveLibraryDeps

return ModuleMapContents(module: name, frameworks: myFrameworkDeps, libraries: myLibraryDeps)
let moduleName = FrameworkBuilder.frameworkBuildName(name)
return ModuleMapContents(
module: moduleName,
frameworks: myFrameworkDeps,
libraries: myLibraryDeps
)
}
}
Loading