Skip to content

[DNM] Test grpc 1.69.1 #15240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[DNM] Test grpc 1.69.1 #15240

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4047517
[DNM] Test grpc 1.69.1
ncooke3 Aug 21, 2025
81f9bc3
fix
ncooke3 Aug 21, 2025
736d6bd
Update Package.swift
ncooke3 Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1408,17 +1408,18 @@ func abseilDependency() -> Package.Dependency {
}

func grpcDependency() -> Package.Dependency {
let packageInfo: (url: String, range: Range<Version>)
return .package(url: "https://github.com/google/grpc-binary.git", branch: "ncooke3-patch-3")
// let packageInfo: (url: String, range: Range<Version>)

// If building Firestore from source, abseil will need to be built as source
// as the headers in the binary version of abseil are unusable.
if Context.environment["FIREBASE_SOURCE_FIRESTORE"] != nil {
packageInfo = ("https://github.com/grpc/grpc-ios.git", "1.69.0" ..< "1.70.0")
} else {
packageInfo = ("https://github.com/google/grpc-binary.git", "1.69.0" ..< "1.70.0")
}
// // If building Firestore from source, abseil will need to be built as source
// // as the headers in the binary version of abseil are unusable.
// if Context.environment["FIREBASE_SOURCE_FIRESTORE"] != nil {
// packageInfo = ("https://github.com/grpc/grpc-ios.git", "1.69.0" ..< "1.70.0")
// } else {
// packageInfo = ("https://github.com/google/grpc-binary.git", "1.69.0" ..< "1.70.0")
// }

return .package(url: packageInfo.url, packageInfo.range)
// return .package(url: packageInfo.url, packageInfo.range)
}

func firestoreWrapperTarget() -> Target {
Expand Down
Loading