Skip to content

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Aug 28, 2025

release.yml version of #15252 which did prerelease.yml

Testing (still running)

release

#no-changelog

@ncooke3 ncooke3 requested review from andrewheard and daymxn August 28, 2025 21:24
@ncooke3 ncooke3 marked this pull request as ready for review August 28, 2025 21:24
Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but is the https://github.com/firebase/firebase-ios-sdk/pull/15269/checks?check_run_id=49136594334 warning something we should address while we're at it? I'm guessing this would be sufficient:

permissions:
  contents: read

@ncooke3
Copy link
Member Author

ncooke3 commented Aug 29, 2025

LGTM but is the https://github.com/firebase/firebase-ios-sdk/pull/15269/checks?check_run_id=49136594334 warning something we should address while we're at it? I'm guessing this would be sufficient:

permissions:
  contents: read

Thanks, @andrewheard. I didn't notice that warning. Fixed.

@ncooke3 ncooke3 merged commit a623ed1 into main Aug 29, 2025
27 checks passed
@ncooke3 ncooke3 deleted the nc/re branch August 29, 2025 15:05
@firebase firebase locked and limited conversation to collaborators Sep 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants